Half-life notification emails continue every notification run

This sounds indeed like a bug: the module should not pick the same ad more than once, and should only notify you once per event, for a total of 5 notifications (half life, expire minus one day, expire, purge minus one day, purge).

Did you find where the error was in its logic to build the list of new ads ?

I've noticed this same problem in version 3.0-rc2 haven't been able to work out how to fix it though.

I've been seeing the same thing. (Drupal 6.24, Classified Ads 6.x-3.0-rc2)

Also, I've been getting this error: "user notice: The classified_notifications_mail() function called token replacement with an array rather than a string for $text in /home/toymania/public_html/modules/token/token.module on line 263."

And then the emails sent out don't have the ad/url populated into them, just the spaceholder text. Is there something obvious I am missing on that?

I'm getting daily emails for Ad half-life. Using version 7.x-3.0-rc2.

Some of your Classified Ads on Roadrunner Region PCA have reached half their lifetime. They are listed below for your convenience.

Please visit your ads list at
http://www.roadrunner-region-pca.org/user/184/classified if you wish to modify them.

(147) 964 Rear Undertray

@dejabobbi : the token issue is a different one. Opening new issue #1491880: Incorrect token generation and use for classified for it.

All: in order to reproduce the problem to fix it:

• do you only encounter this problem only with half-life or also with others ?
• do you encounter it on multiple ads, or only when there is only one ad being notified, as dglason seems to imply ?

The problem for me only appears to be with the half life one, none of the others get sent out repeatedly.

Seems to happen regardless of how many ads are being notified.

OK, so digging into it, there is one more issue: the tokens code backported from D7 just does not work as such. That's why D6 users don't get the ads list. Details in #1491880: Incorrect token generation and use for classified.

At this point, if you use the latest 6.x-3.x version, the only remaining problem on that list should be the repeating half-life message: no more warning, no more unreplaced tokens. Please check !

Here is a test case catching the problem. Does it match what you observed, or does it need more test assertions ?

Actually, with even further checks, the module was operating as designed, sending up to one mail per 12 hours, to "push" users.

Since this seems to be undesired, I changed the logic so that no mail gets sent more than once on an untouched ad.

Ooops, patch is rolled against latest dev, not RC2.

The latest dev with the original half_life_notifications_resent-1441396.patch I can confirm didn't stop the repeat emails as you since worked out. I am now testing the latest dev with the 0001-Issue-1441396-by-fgm-change-in-notification-frequenc.patch in post #12

Lurch indeed: the initial patch only added the test to catch the error, but not the fix :-)

Committed to 7.x-3.x too. All should work on 6.3 and 7.3 now. Please review, and we can release the stable versions if you confirm the issue is fixed for you all when using the latest dev versions.

All appears to now be working as expected for me with the 6.x-3.x-dev version.

OK, considering fixed, then.