Closed (fixed)
Project:
Address Field
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Feb 2012 at 20:58 UTC
Updated:
29 Dec 2014 at 21:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
adam_b commented+1
Comment #2
klonos...you've beat me by a couple of days in filing an issue for this ;)
Comment #3
guillaumev commented+1
Comment #4
kojow7 commented+1
Comment #5
Eric Anfrui commented+1
It would be great
Comment #6
warmth commented+1 any news?
Comment #7
rszrama commentedThat module takes a pretty heavy-handed approach to countries by making every country into an editable entity. It's very feature-rich, but it also seems a bit much for Address Field to depend on. My recommendation would be either 1) a feature request in that module to replace itself into the Country select list used by Address Field or 2) a contributed module that ties them together, likely through an address field format plugin.
Also, I'm not really sure what the integration between these two modules would really look like. I don't think it should just be a simple case of "call this function to get a countries list instead of that one", though that would be a good starting point. Could be some tie-in to #1829900: [meta] Address Field 2.x needs pluggable administrative areas and an actual API.
Comment #8
klonosNobody suggested anything about depending on the module rather about supporting it if installed. Hope the title change makes that clearer now.
PS: don't mean to ping/pong status change with you, just don't want this clarification to drop off your radar in case you filter closed issues out of view. Thanx and sorry.
Comment #9
jnicola commentedAdded patch that alters the list of countries in function _addressfield_country_options_list() so as it uses the countries module method of getting countries if the module exists and is enabled. If not, uses standard approach.
I also removed the second setting of $countries in the if statement within the foreach. This seems redundant and purposeless. I wish there was a comment to explain why this was placed there, but since there wasn't, and both a code review and testing demonstrated this as useless locally, I have removed it for simplicities sake.
Comment #10
jnicola commentedComment #11
bojanz commentedWorks fine. Committed, thanks.