I first have problem when I edit node with a video thumnail. I can't save the form because I get this error:
The file used in the Video thumbnail field may not be referenced.
I can delete the file trough the Ajax UI and I get:
Notice: Undefined index: thumbnail in file_ajax_upload() (line 261 of mysite/modules/file/file.module).
This is another core bug #1067470: PHP notice on AJAX upload for file_managed fields added during element #process callback and #1217802: Notice: Undefined index: thumbanail in file_ajax_upload() (line 256 of modules/file/file.module).
but I'm able to add a image and save the node
If I edit the node again I will have the issue again..
I saw is thumbnail files are not added in the file_usage table. I try to add the thumbnail file manually in file_usage and everything was fine after... no more error.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | implementing patch.txt | 21.38 KB | ivanhi |
| #2 | 1441626-2-commit_5eaeb084baf6.patch | 5.81 KB | gagarine |
Comments
Comment #0.0
gagarine commentedUpdated issue summary.
Comment #0.1
gagarine commentedUpdated issue summary.
Comment #0.2
gagarine commentedUpdated issue summary.
Comment #0.3
gagarine commentedtypo
Comment #1
gagarine commentedThe problem is around video_field_presave, insert and update.
Btw, why the thumbnail is not saved in a standard image field?
Quick fix:
- in the video_field_insert function add file usage for each added thumbnail
- in video_field_update remove usage and add a new one
- in video_field_delete remove usage and file.
This sound ok for you?
Comment #2
gagarine commentedHere a patch than should solve the problem. This certainly also need an update path to add all the file file_usage table...
Again, I think the storage structure should be different. Also the video can be only a wiget for a standard file field with some metada... Now video field wrap some file_field hook to save the video field... not sure it's a very good practice.
Comment #3
andypost@gagarine having custom field is right choice but problem in widget implementation
agree with strange behavior about thumb but current version of the module saves thumb but editing of the node broken (with your patch too)
The file used in the Video thumbnail field may not be referenced.Comment #4
gagarine commentedWith my patch if you create a new node you can still not edit/delete them without problems? It works for me :/. As I say nodes created before patched will not work and we need an upgrade path.
Comment #5
gagarine commentedCan someone test and review with new nodes and confirm this patch works (or not). I can provide after a upgrade path when I know the system works.
Comment #6
ivanhi commentedI'm really greatefull. I have spent many hours looking for a solution to the mad message The file used in the Video thumbnail field may not be referenced. but I have implemented your patch and the problem is fixed.
I haved to erased the previous thumbnail and then upload again it with the content already uploaded.
I have no much idea about using patches, so I will be really glad if you can check If I used it properly.
Thanks a lot.
Comment #8
Jorrit commentedI have committed a fix that is similar to the patch but tries to reuse the
file_field_*functions where possible. I have also fixed the situation where the default thumbnail is deleted when the last video that uses it is deleted. The notices are also gone.Please test the next 7.x-2.x-dev release (current one is: March 2, 2012 - 01:43) and let me know if all your problems have been fixed.
Comment #9.0
(not verified) commentedUpdated issue summary.