As mentioned here http://drupal.org/node/1366628#comment-5564012 from tomceek correctly, the solution to solve the issue #1366628: Warning: strpos() expects parameter 1 to be string, array given in _link_sanitize()...Line 509 of link.module. is rather an option than a whole take off or cut of failing code, since some may would like to play around with it a little bit more.

But finally I came to the conclusion that it makes more sense to better inject a more "complete" solution for an optional automatic rel removal if link is internal or external (depending on settings). By default the setting is to leave rel as set up before.

This way it makes it possible to decide for best practicees on the project with links from the admins side.

CommentFileSizeAuthor
#13 link-automatically-1141702-13.patch834 bytesjsagotsky
#5 rel_attr_option_on_off_if_internal_external-1441702-5.patch2.66 KBdqd
#4 rel_attr_option_on_off_if_internal_external-1441702-4.patch2.59 KBdqd
#3 rel_attr_option_on_off_if_internal_external-1441702-3.patch3.05 KBdqd
#2 Selection_057.png160.24 KBdqd
#1 Link Test | Digidog's scratchpad - Mozilla Firefox_053.png44.95 KBdqd
#1 Selection_054.png184.08 KBdqd
#1 Selection_055.png30.08 KBdqd
#1 Selection_056.png231.91 KBdqd

Comments

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
StatusFileSize
new Selection_056.png231.91 KB
new Selection_055.png30.08 KB
new Selection_054.png184.08 KB
new Link Test | Digidog's scratchpad - Mozilla Firefox_053.png44.95 KB

Here are some screenshots how the change works and the patch follows. EDIT: the last picture should be shown first and then the 1. 2. and 3th. to understand the setting.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
StatusFileSize
new Selection_057.png160.24 KB

heh ... oh man, sorry second picture is for the thirth setting. Here comes the correct 2nd picture for the setting of the thirth picture ...

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
StatusFileSize
new rel_attr_option_on_off_if_internal_external-1441702-3.patch3.05 KB

And here comes the patch ...

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
StatusFileSize
new rel_attr_option_on_off_if_internal_external-1441702-4.patch2.59 KB

huh? ok ... obviously some coding standart failure I found later ... Here is an optimized version without trailing spaces (hopefully)

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Active » Needs review
StatusFileSize
new rel_attr_option_on_off_if_internal_external-1441702-5.patch2.66 KB

ok, after some wishes from IRC :-) ... here a version with better readable code but slidely more kb ;-)

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Needs review » Reviewed & tested by the community

ok, tested on 4 stages with different modules installed and different Drupal 7.x versions on Linux and Windows server. I would say ... for such a radios/form addon patch ... I can take it as "tested" to get the stuff in tonight ...

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Reviewed & tested by the community » Fixed

committed and pushed to HEAD. (--dev)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

thanks Digidog :-P :-D :-D

jsagotsky’s picture

jsagotsky commented
StatusFileSize
new link-automatically-1141702-13.patch834 bytes

The patch in 5 and now in HEAD misspells automatically. Here's a patch (on 7.x-1.x) to fix it.