If a user account isn't connected to Facebook and the user goes to their edit page/facebook settings, they get shown the 'deauthorise' text, which is a little misleading. I've attached a diff that shows different text and the 'connect' button if they aren't connected (feel free to modify any/all of it.)

CommentFileSizeAuthor
#1 fboauth_user_info_connect-d6.patch2.06 KBquicksketch
#1 fboauth_user_info_connect-d7.patch2.06 KBquicksketch
fboauth-allow-connect-settings.diff1.87 KBdarrylh

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed
StatusFileSize
new fboauth_user_info_connect-d7.patch2.06 KB
new fboauth_user_info_connect-d6.patch2.06 KB

Thanks I ported it to D6 and committed both patches to the project.

I'd seen this before but didn't figure it was much of a problem since there isn't a link to user/%/fboauth unless the user is authorized, but you're right that there's nothing stopping the user from visiting the URL when they're not authorized, thus leading a confusing page asking the user to deauthorize when they didn't authorize to begin with.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.