I know there hasn't been many changes to this module since 2010 but as it is such a simple and great module that I would like to propose a few changes that will improve it a little bit.

I have created a bulky patch that actually includes other patches that fix some small issues that have been sitting in the issue queue for a while now. Here they are:

- #1099928 - Applied patch that makes the module comply with Drupal's code standards. (Thanks to Sutharsan)
- #1409902 - Applied patch (comment #3) that fixes the path and does it the D7 way under the permission page as a tab. (Thanks to jorgegc)

Also, I have improved it a little bit by allowing users to select different themes for site and administration pages which I thought was missing in this module. And to be able to do so I had to bump the version in the .info to 7.x-1.1 so that I could implement role_theme_switcher_update_7011 in a .install file and make sure the upgrade path is smooth.

Please consider testing out my patch and rolling out the 7.x-1.1 release if there is no issues with it. Thanks!

CommentFileSizeAuthor
#1 role_theme_switcher-different_themes_site_admin_pages-1441940.patch4.74 KBjorgegc

Comments

jorgegc’s picture

jorgegc commented
StatusFileSize
new role_theme_switcher-different_themes_site_admin_pages-1441940.patch4.74 KB

And here is my patch!

tiutiun’s picture

tiutiun commented
Assigned: Unassigned » tiutiun
tiutiun’s picture

tiutiun commented

Hi jorgegc,

Thank you very much for your contribution - it is always appreciated.

I see that patch now creates two select boxes for each role.

I am wondering what could be the use case that Anonymous role would have access to admin pages?
I also have a feeling that this added functionality overlaps the "Use the administration theme when editing or creating content" functionality.

Please correct me if I am wrong.

jorgegc’s picture

jorgegc commented

Hi tiutiun,

I just thought we should be consistent and have anonymous as part of the administration theme settings as well. There might be a case where someone wants to give permission to anonymous, who knows :)

Hmmm... No, I don't think they are overlapping. If you don't check the "Use the administration theme when editing or creating content" box those pages are not going to be considered as "administration pages" therefore Drupal will use whatever you set the "site theme" to be in the settings of your module.

I hope my comment is not too confusing!

j4’s picture

j4 commented

Hi,

Just wanted to let you both know that i applied the patches and that the module works perfectly for me if i keep the admin theme as default in the appearance page and then select admin themes in the role switcher page.

Thanks for this superb module and for the patch!
Jaya

jorgegc’s picture

jorgegc commented

Hi Jaya,

You are welcome. Now it is up to the module maintainer to decide whether he wants this feature in his module or not. Let's hope he says yes :)

Cheers,

Jorge

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Issue summary: View changes

Patch works for me too. However, as @j4 said, you have to select administration theme as "Default theme" on admin/appearance to make new options work as expected.