Changes to the installer system to introduce default.settings.php, the configuration form and the locale import went in without an update to the INSTALL.txt. I promised in the last issue to provide a patch to update the documentation. I would welcome reviews of this patch, so we get a clean updated documentation on how Drupal 6 installation works.

Changes:

- The Drupal 5 changes section removed, I am not sure we need one for Drupal 6
- PHP4 and PHP5 are PHP 4 and PHP 5 (version is not in the name)
- Jabber reference removed, it is not a core feature
- Add information about translations
- Add information about permission requirements on sites/default
- Add a small hint of information about the configure screen, and that sites/default will be tried to be made write protected
- Removed "create admin account" from the Welcome page task list referenced
- Fixed module enable page breadcrumb
- Removed "now" from phptemplate sentece, because it has been for a while :)

Please review (especially the permission parts).

CommentFileSizeAuthor
#6 installtxtupdate_3.patch7.54 KBkeith.smith
#4 installtxtupdate_2.patch7.13 KBbdragon
installtxtupdate_1.patch7.11 KBgábor hojtsy

Comments

bdragon’s picture

bdragon commented
Status: Needs review » Needs work

patching file INSTALL.txt
Hunk #6 succeeded at 86 with fuzz 2.
Hunk #7 succeeded at 122 (offset 6 lines).
Hunk #8 FAILED at 148.
1 out of 9 hunks FAILED -- saving rejects to file INSTALL.txt.rej

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Document the installer changes (settings.php, configuration form, locale import) » Beta breaker: Document the installer changes (settings.php, configuration form, locale import)

I would love if someone would reroll this patch, although I don't have the time inbetween patch reviews to do it. INSTALL.txt is still in a very outdated state and new/changed stuff needs documented. I am marking this a beta breaker, because the INSTALL.txt says just plain nonsense and is not in line with what needs to be done now.

bdragon’s picture

bdragon commented

Roger that, pushing it onto my stack. ;)

bdragon’s picture

bdragon commented
Status: Needs work » Needs review
StatusFileSize
new installtxtupdate_2.patch7.13 KB

OK, most of that hunk is fixed in head anyway. Rerolled.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Great, thanks. I am tempted to commit this right away (IMHO it looks good enough :), but being my suggested changes, I'd love to have someone else reread the patched INSTALL.txt and see if everything is all fine.

keith.smith’s picture

keith.smith commented
StatusFileSize
new installtxtupdate_3.patch7.54 KB

I read through the patched INSTALL.txt and all the changes seem fine (good, even!).

Though not the fault of this patch, I did notice a line near the end of the file that read "addition to those installed in the standard 'modules'and 'themes' directories." I've modified that line in the attached patch (which is hopefully well-formed) to include a space between 'modules' and the word 'and'.

This is, however, a new patch so I hate to RTBC (but otherwise would).

Frando’s picture

Frando commented
Status: Needs review » Reviewed & tested by the community

Patch applies and all the changes are looking great. RTBC.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Wow, thanks for picking up. Committed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)