Link doesn't work for me

Link doesn't work for me too

I tried to reproduce the issue with a fresh drupal 7.12 and field_slideshow 1.6 but haven't succeeded.

Can you give more details on your setup? There is no link at all or is it wrong?

I'm having the same problem. The issue seems to be linking to content in the teaser when using views to display a number of teasers.

I have the same problem and same setup as mentioned in #3. The link doesn't get generated (I mean, there's no <a> in the html) in a view of teasers, when the slideshow is set to link to content, but it works when is linking to file. The only field shown in the teaser is the slideshow source (the other fields are hidden).
Other than the link problem, the slideshow works fine.
Installed: Drupal 7.14, Field Slideshow 1.6, Views 3.3.

I can add now that the same happens if the view format is "Fields" instead of "Content".

I can confirm this issue.

In my case, "Link to content" doesn't work regardless it's a teaser node or a full node.

If I select the option link to file or colorbox everything works fine.

The modules versions are the same as hgmartini's.

subscribe!
same problem here! Link to content doesn't work

For Everyone's Information, this bug is fixed on the dev version.

If you don't want to upgrade yet, a quick fix is commenting line 577 on field_slideshow.module.

Original line:

$uri = array();

You could remove the line or comment like this:

// $uri = array();

That worked for me.

I confirm this problem on D7.15 using minimal profile, link to content doesn't work.

@maxelli: Are you using the 1.6 version? If so, can you try with the modification explained in #8?

Hi idflood,
yes, I am using 7.x-1.6 at the moment. I just have applied the modification from #8 and it worked for me, but I think the $uri declaration should be placed at the beginning of the loop for required fields.
I've attached a patch for the current dev branch to show you what i mean with some small changes.

Hi hauptm,
Thanks for the patch and the feedback. I'm not sure to understand the reason of some of your changes.

For instance

-    $entity_info = entity_get_info($entity_type);
-    $entity_id_field = $entity_info['entity keys']['id'];

They are moved inside the "subloop", but since $entity_type doesn't change I would have moved them outside.

-          $uri = $content_uri;
+          $uri = entity_uri($entity_type, $entity);

Same situation as above, $entity and $entity_type don't change so why not declare it outside of the loop?

But for the $uri declaration and check you are right, it looks cleaner the way you did it :)

Does the changes I propose make sense to you?

Yeah you're right, leave them outside. It was just late in the night and for me it made sense to place the declarations near where you need it.

Your patch from #12 is working for the dev only, but that's what it should and makes sense.

Thanks for your patch.

Thanks, committed patch #12.

But my change on line 601, the $uri declaration is also dispensable in the dev branch.

foreach ($links as $setting => $path) {
    $uri = array();

because $uri is only needed in the sub-loop. Sorry for that :(

good catch, thanks : )