Administrators should be able to customize more display options of videos on their site. It seems to me that it should be done in Configuration » Media » File types » Manage file display for each displays on the same level than autoplay.

This patch allows that and add the following options :

  • Color
  • Show Portrait
  • Show Title
  • Show Byline
  • Loop

This issue is almost the same than #1229304: Video display settings but for drupal 7.

CommentFileSizeAuthor
#5 media_vimeo_1443092.patch9.47 KBdrewish
display_settings.patch8.99 KBnikosnikos

Comments

smbell’s picture

smbell commented

Patch works. Thank you!

earlstudios’s picture

earlstudios commented

this is just what I need...stupid question, I can't seem to find out how to apply a patch to a website that is hosted with siteground? please don't hit me for asking a redundant question, i'm a food photographer, i pay in cupcakes :-)

drewish’s picture

drewish commented

Seems like there's some overlap with #1381256: Add portrait, title and byline option. I think both add a lot of code for something that should be pretty simple. I think we should find a simpler way to handle the settings. Those accessor functions just seem noisy. Why not simply expose an array of settings?

drewish’s picture

drewish commented

I'm going to close the other issue since its patch is busted. I'll give this a closer look.

drewish’s picture

drewish commented
Title: Video display settings in D7 » Add more video display settings, switch to universal player.
StatusFileSize
new media_vimeo_1443092.patch9.47 KB

I want to merge #1494020: Adding option for use of vimeo API in with this since it touches the same code. I'm also switching to the IFRAME so I'll merge the issue at #1457838: Switch embed to new Universal Player to provide iOS HTML5 support into this one as well.

Since the styles support is deprecated #1503158: Remove support for Styles module I don't think we should add support to that code for the new features.

Pls’s picture

Pls commented

Thanks drewish, right now I'm preparing to test your patch, will report back my results.

bentekwork’s picture

bentekwork commented

I just tested this patch from #5 and it works as expected on my installation. Thanks!!

drewish’s picture

drewish commented
Version: 7.x-1.0-beta4 » 7.x-1.0-beta5
Status: Needs review » Fixed

Okay i'm pretty happy with it so I went ahead and pushed it.

Pls’s picture

Pls commented

Yes, patch works without any problems. Do you plan to release new beta soon ?

drewish’s picture

drewish commented

You can grab the dev build when it's updated. I'm not in a hurry to push out a new beta yet. I'd rather try to close up the remaining issues and get to an RC.

ghazlewood’s picture

ghazlewood
Location Hampshire, UK
commented

I've just been working with the updated -dev version as I need API support to allow me to control when the vimeo video plays. In order to do this I need to pass the Froogaloop function a playerID according to the Vimeo JS API. At the moment the wrapper element gets the ID not the iframe. Would it be unreasonable to suggest applying the existing wrapper_id to the iframe instead of the div? I can provide a patch against -dev if this would be ok.

RobW’s picture

RobW commented

@ghazlewood sounds like a great idea (I would use it), but deserves its own issue.

ghazlewood’s picture

ghazlewood
Location Hampshire, UK
commented

Ok cool, will get my things together and open a new issue with this specifically. Thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.