Closed (cannot reproduce)
Project:
phpBB2Drupal
Version:
7.x-2.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Feb 2012 at 01:06 UTC
Updated:
22 Oct 2012 at 14:58 UTC
Imported forums structure may be broken as the sort order of forums is not 100% correct in some circumstances. Adding ->orderBy('forum_type') makes sure the main categories come first.
diff -crB ./drupal/sites/all/modules/phpbb2drupal_old/phpbb2drupal_core.inc ./drupal/sites/all/modules/phpbb2drupal/phpbb2drupal_core.inc
*** ./drupal/sites/all/modules/phpbb2drupal_old/phpbb2drupal_core.inc 2012-02-17 00:53:28.000000000 +0000
--- ./drupal/sites/all/modules/phpbb2drupal/phpbb2drupal_core.inc 2012-02-17 00:54:30.000000000 +0000
***************
*** 224,229 ****
--- 224,230 ----
->select('{forums}', 'f')
->fields('f', array('forum_id', 'parent_id', 'forum_name', 'forum_desc', 'forum_type'))
->condition('forum_type', 2, '<>')
+ ->orderBy('forum_type')
->orderBy('parent_id')
->orderBy('right_id')
->orderBy('left_id')
Comments
Comment #1
darksnowI've added this to my local copy of the code and while it doesn't have any adverse effect, it also doesn't seem to do anything.
A sort order is required to the "high water mark" feature of migrate so this is all good, but I was wondering if you could elaborate a little on what problem you are seeing.
Cheers.
Comment #2
JeremyFrench commentedI think this issue is fixed in the more recent versions of the module. Please reopen if this is still an issue for you.