Needs review
Project:
Drupal.org drush
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Feb 2012 at 02:24 UTC
Updated:
8 Mar 2012 at 18:03 UTC
Jump to comment: Most recent file
Using drush's cache for release_info_fetch drastically speeds up testing. However, when running this on d.o., this patch would still allow specifying --no-cache so the most up-to-date release info is available when verifying make files.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1443410-1.drupalorg_drush-use-cache.patch | 741 bytes | dww |
| drupalorg_drush-use-cache.patch | 736 bytes | jhedstrom |
Comments
Comment #1
dwwRerolled after recent changes. However, I've got some concerns. This seems to be a global thing, not something we're setting just around the release_info_fetch() code and resetting. Therefore:
A) Does this setting impact anything else drush make is doing while it runs? I don't know, but I wanted to ask. Don't have time today to do a more thorough audit, but I wanted to raise it.
B) If it's just a global thing, why not do this once inside drupalorg_drush_drush_init() instead of doing it over and over inside drupalorg_drush_find_release_node() (which could be called dozens of times on a moderately complex .make file).
Thoughts?
Thanks,
-Derek