Thanks for this great module of yours.

I have a site where I installed this module, and I have it working just fine. The only problem I have is that I have a person designated to do user administration. I can't let him handle the roles w/o giving him access to all permissions. It would be nice if there were other ways (taxonomy, profile, cck, etc.) of specifying which users to send to.

CommentFileSizeAuthor
#6 mass_contact-144343-grouping-methods-comments.patch19.58 KBygerasimov
#4 mass_contact-144343-grouping-methods-comments.patch0 bytesygerasimov
#2 mass_contact-144343-grouping-methods.patch18.93 KBygerasimov

Comments

ygerasimov’s picture

ygerasimov commented
Version: 5.x-1.x-dev » 7.x-1.x-dev

I would love to move this feature request to 7.x branch.

I my case I really need creating category by taxonomy term attached to user.

ygerasimov’s picture

ygerasimov commented
Status: Active » Needs review
StatusFileSize
new mass_contact-144343-grouping-methods.patch18.93 KB

Please review attached patch. I have built ctools plugins for extension of grouping options.

In order to try taxonomy method you need to add taxonomy term reference field to user object and add some terms to users.

oadaeh’s picture

oadaeh commented
Status: Needs review » Needs work

Thanks so much for submitting that patch. I really like the concept, and so far It looks good, but there are aspects of it I'm not sure about, and the commenting is rather sparse. I'm sure you can understand my not wanting to commit code where I don't know what is going on. Would you please add some more comments to it so that I can follow along with what is happening? I will, after all, be maintaining it in the future. Thank you.

ygerasimov’s picture

ygerasimov commented
Status: Needs work » Needs review
StatusFileSize
new mass_contact-144343-grouping-methods-comments.patch0 bytes

I have added some more comments to the code. Please see code of role plugin.

I have written article about ctools plugins system http://ygerasimov.com/ctools-plugins-system

I am happy to discuss any questions you might have on IRC.

oadaeh’s picture

oadaeh commented

Your last attachment is 0 bytes, so it didn't make it into the system.

ygerasimov’s picture

ygerasimov commented
StatusFileSize
new mass_contact-144343-grouping-methods-comments.patch19.58 KB

Oops. Here is proper patch.

oadaeh’s picture

oadaeh commented
Status: Needs review » Fixed

I have committed the patch in #6 here: http://drupalcode.org/project/mass_contact.git/commit/358398b.

Please do take a spot check to make sure everything looks okay.

I did fix a logic bug in the roles plugin where selecting the authenticated users role resulted in selecting no users, much like this bug: #1353504: No users were in the selected category.

Thanks again for doing this. Now I'm going to have to go through and create plugins for all the feature requests.

ygerasimov’s picture

ygerasimov commented

great thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

oadaeh’s picture

oadaeh commented
Component: Code » Categories

Changing the component for future reference.