fix for a typo on page.tpl.php primary menu div
ica - May 16, 2007 - 01:19
| Project: | The Orchard |
| Version: | 5.x-1.2 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Psicomante |
| Status: | closed |
Jump to:
Description
<div id="primary">
<?php print theme('links', $secondary_links, array('class' => 'links secondary-links')) ?>
</div>i presume should be
<div id="primary">
<?php print theme('links', $primary_links, array('class' => 'links primary-links')) ?>
</div>also seperately a fix sidebar div position is not so good idea in general as blocks can not expand on fix positions -imho
#1
Thanks for the issue. If you would. Send me a patch where you want to see the sidebar block. I will include as a separate theme, in the Orchard pack. What is the best position?
#2
The issue has been fixed. Thanks!
#3
I think i misunderstood you advice :) You think that the sidebar should be in a absolute position, but not fixed. Right, because if the sidebar is too long it doesn't scroll. I could make a spearate css for fixed/not-fixed position. Thanks!
#4
sorry i should make more clear where the typo is
its on page,tpl.php
the primary menu poibts to the secondary menu, as result the theme get the secondary menu instead of the primary menu and the seconday menu repeated twice
hope my sedcription makes sense
#5