I'm using the search autocomplete for a project and found out the javascript wasn't optimal and it wasn't using drupal behaviors (thus not working in some ajax-specific situations).

I made a patch that changes the implementation to Drupal behaviors.

It also fixes a small issue with a trailing , that should fix ie6 issues (not that it's important anymore but removing a , didn't seem like too much work :)).

It also disables the immediate focus on the input field. This is more a requirement for the project I'm working on but it seems to me that setting the focus is not desirable. When doing this we assume the user will find the search field the most important input field on the page, which it is generally not..

I hope you'll find this patch of use. It's created with SVN from as I don't know yet how to make a GIT patch, hope you don't mind..

CommentFileSizeAuthor
search-autocomplete-drupal-behavior.patch1.67 KBmichielnugter

Comments

dom.’s picture

dom. commented

Hi!

Thank you very much for your work! I will have a look at it and most likely include it in a next release.

Miro

dom.’s picture

dom. commented
Status: Needs review » Patch (to be ported)

Hi!

Thanks a lot for your help. Sorry I had no time to review it earlier. It's done now. I also used your work to make a D7 version using Drupal.Behaviors. It will be ported soon!

Miro.

dom.’s picture

dom. commented
Version: 6.x-2.2 » 7.x-2.3
Status: Patch (to be ported) » Fixed

Should be fixed in 7.x-2.3 !

Miro.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.