When altering views_form in function _dc_cart_ajax_form_views_form_alter() you attach javascript file like this:

// dc_cart_ajax.module:28
$form['#attached']['js'] = array(
  drupal_get_path('module', 'dc_cart_ajax') . '/misc/js/dc_cart_ajax.js'
);

This causes a problem that if there are other attached JS files (let's say altered by other modules), your code overrides the whole array.

This should be fixed with:

$form['#attached']['js'][] = drupal_get_path('module', 'dc_cart_ajax') . '/misc/js/dc_cart_ajax.js';
CommentFileSizeAuthor
#1 1444018-1.patch816 bytesimiksu

Comments

imiksu’s picture

imiksu
Location Finland
commented
StatusFileSize
new 1444018-1.patch816 bytes

Here's a patch.

imiksu’s picture

imiksu
Location Finland
commented
Status: Active » Needs review
thehong’s picture

thehong commented

Pushed. Thanks.

thehong’s picture

thehong commented
Status: Needs review » Fixed
lalit774’s picture

lalit774 commented

#1 working fine for me. now both(Commerce Cart Ajax, commerce_extra quantity ) modules working together.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mrpauldriver’s picture

mrpauldriver commented

confirm that this now works for me

Exploratus’s picture

Exploratus commented

#1 works for me. Lets get this committed no? I was having issues with commerce_extra_quantity.

fox_01’s picture

fox_01 commented
Issue summary: View changes

Is that patch commited to latest dev?

fox_01’s picture

fox_01 commented

Is that patch commited to latest dev?

plazik’s picture

plazik commented

@fox_01, yes, it was commited to dev.

mozh92’s picture

mozh92 commented

comment in function dc_cart_ajax_form_commerce_cart_add_to_cart_form_alter

function dc_cart_ajax_form_commerce_cart_add_to_cart_form_alter(&$form, $form_state, $form_id) {
  $form['submit']['#ajax'][] = array('callback' => 'dc_cart_ajax_form_commerce_cart_add_to_cart_form_ajax_callback');
  //$form['submit']['#attached']['js'] = drupal_get_path('module', 'dc_cart_ajax') . '/misc/js/dc_cart_ajax.js';
  $form['#submit'][] = 'dc_cart_ajax_form_commerce_cart_add_to_cart_form_submit';
}

for Commerce AJAX Add to Cart
1. $form['submit']['#ajax'] => $form['submit']['#ajax'][]
2. $form['submit']['#attached']['js'] => //$form['submit']['#attached']['js']