If I may, I'd like to add my two cents as to how I think the UI of this module could be improved to better usability and allow for more features to be integrated.

Non-UI related comments in quotes

This feature request is based on comments and discussions in other threads. But has a number of new ideas / features that are unrelated.

The current 'Groups' and 'Channels' collapsed field sets should really be implemented as tabs under admin/settings/adsense. 'Groups' should be renamed 'Colors', or 'Color sets' or something similar.

The number of groups (8) and channels (7) should not be set anywhere by a variable. Rather, on a new installation there should be only 1 default group, and no channels. An adsense admin can then create as many new groups as they wish, and up to 200 channels.

Whether this data is then stored in variables table or a new adsense table is of no significant relevance to the UI, however I suggest if the variables table can support the largest possible amount of data that 'Color sets' and 'Channels' may need to store without exaggerated cost to performance, then there is no reason not to. That's what the variables table is for, I believe.

Every channel and group should be identifiable by an alias/nickname in the UI.

Channel ID in adsense.module is pointless when google's channel ID is also a unique integer. Using an integer-ID in the UI is problematic, whether it's a one or ten digit integer. Hence drop the adsense module channel ID, introduce a channel alias, and obviously maintain the google channel ID.

Separate but related features:

  • The 'Color sets' interface should ideally have a color picker introduced on the color set edit form, like the color module has implemented on garland theme settings form. A preview area would be nice, although possibly conflicting google adsense' T&C's.
  • It'd be nice to be able to import color sets from google.com/adsense/code, or existing embedded adsense ads in templates or other pages / sites. This feature would be similar to what Wesley proposed as option 3 The importing function would need to parse the code and store the settings as fields for editing (with either the current interface or the color picker as proposed above). It would discard some settings from the google generated code such as the ad dimensions and channels.

Comments

Bevan’s picture

The number of groups (8) and channels...

Correction, there are 5 groups, not 8, by default.

kbahey’s picture

Title: UI improvements » User interface improvements for colors and channels

These are reasonable features.

Anyone care to submit patches?

Bevan’s picture

I'd like to -- sometime. However 'time' is the critical word in the previous sentence.

I have a lot of ideas and suggestions for usability improvements all around drupal -- and not enough time for them. So in the vein of the 'improve the UI' consensus, for now I'm just writing them down at least, so that others can perhaps consider, comment or even implement them...

Maybe I'll get around to this one some time, but don't wait for me if you or anyone else is considering implementing any such changes...

dennys’s picture

Version: 5.x-1.x-dev » 5.x-1.6
Status: Active » Needs work

I wrote a patch to enhance the channel configurations. There is a separate tab for channel now and there are 2 sub tabs "list" and "add" of it. The "list" tab is working now, but "add" is not. Because I found maybe we need to change the data structure of channel. For current structure, I need to scan the table and find the MAX channel number when adding a new channel.

I think this patch still needs some work, do you have any suggestion for it ?

Btw, I also add a "channel name" for it (only in channel setting gui now), like the alias. I think it's good to use the name instead of the actual channel id.

Bevan’s picture

Woohoo! Glad someone is working on this. This is a terrible usability bug. I'll review it for you, if you upload the patch! ;)

dennys’s picture

StatusFileSize
new6.17 KB
new3.82 KB
new8.04 KB

Sorry, forgot to attach files. Please check screenshot and patch.

dennys’s picture

Hi,
is there any suggestion for it ? I think it's possible to modify the channel configuration to let it more friendly and I can help it. Please give me some feedback, thanks.

Bevan’s picture

Status: Needs work » Needs review

It'd be good to get some adsense.module maintainer's eyes on it.

dennys’s picture

Status: Needs review » Needs work

This patch is not completed yet (so, I changed it to "code needs work"), the "add" function is not working now.

I just want to confirm is anybody interested in it and get some feedbacks.

btw, my opinion is that it's better to change the data structure from 1 channel vs. 1 database record to maybe a array or others... I think it's better to maintain.

Bevan’s picture

Please set it back to review when it's complete. Sorry I haven't had time to review this. Part of the problem is that I no longer maintain any d5 sites that use it, so I would need to set it up from scratch. Once you think it's complete I'll take the time to review it though! :)

jcnventura’s picture

Status: Needs work » Postponed (maintainer needs more info)

Hi,

There's not much point on this anymore with Google removing the color settings from the Adsense user-side script. I don't think anybody still wants this, but I will leave this issue here for two weeks before closing it.

João

jcnventura’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

No info in more than two weeks. Closing the issue.

João