Hi,
Thank you for building this add on to Drupal Commerce.
I have my site in Dutch and would like to use Dutch language for RRP and Offer Price in Priceformatter: RRP/ Your Price.
But I can't find RRP and Offer Price in translateble area?

Greetings, Martijn

CommentFileSizeAuthor
#5 labels_not_translatable-1444168-3.patch1.28 KBguy_schneerson

Comments

ikos’s picture

ikos commented
Assigned: Unassigned » ikos
Status: Active » Fixed

Hi Summit,

Thanks for the feedback. I have ensured all fields are translatable in the latest version.

kind regards

Richard

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

guy_schneerson’s picture

guy_schneerson commented
Category: feature » support
Status: Needs review » Needs work

The fields defaults are translatable but the following two issues exists

  • Changes to the the labels don't show in the translate interface.
  • The labels while available in for translations don't actuality get translated.

This is because t() is not used by the rendering code (simple patch to follow)

guy_schneerson’s picture

guy_schneerson commented
Category: support » feature
Status: Closed (fixed) » Needs work
guy_schneerson’s picture

guy_schneerson commented
Status: Needs work » Needs review
StatusFileSize
new labels_not_translatable-1444168-3.patch1.28 KB

Patch fixing the issue

Status: Needs work » Needs review

Correcting issue status, see #2125263: Issue status not taken from last comment during D7 migration.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: ikos » Unassigned
Issue summary: View changes
Status: Needs review » Needs work

The first parameter for t() needs to be a literal string. It considered a security issue to pass to t() a value entered in a form by users.