Closed (fixed)
Project:
Redirect
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Feb 2012 at 19:12 UTC
Updated:
19 Jan 2015 at 21:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
chris-cmfi commentedAlso cleared all cache (no pages are being cached), ran cron, and updates.
Will try dev version along with this patch (http://drupal.org/node/1198028) to see if that works.
Comment #2
chris-cmfi commentedThe module is set to not redirect when in maintenance mode though my site has been in maintenance mode the whole time (not yet live).
Updating the variable from FALSE to TRUE alleviated my issue.
elseif (variable_get('maintenance_mode', 0) || defined('MAINTENANCE_MODE')) {
// Do not redirect in offline or maintenance mode.
$can_redirect = TRUE;
Line 1093 'redirect.module' in DEV version
Comment #3
nhck commentedAs outlined above the module does not redirect when the site is in maintenance mode. Whilst this behavior makes perfect sense Redirect shouldn't provide a 404 page to logged in users. In my humble opinion it would be nice to display a message to users that are logged in (permission to use site in maintenance mode) and a 404 (or maintenance message) to users that are not logged in.
Comment #4
obleser commentedAggree with all of the above!
It took me 1 day (!) to find this post (Tried all of the things mentioned by #1)
#2:
same here :/
The proposal of #3 sounds great.
By the way: A simple system warning message on the redirect config page in maintenance mode were enough...
Comment #5
alforddm commentedI vote for #3 as well. So glad I found this post!
Comment #6
clemens.tolboomComment #7
clemens.tolboomSee also #1795224: Redirect not working in Maintenance mode
Call to watchdog should add 'warning' and no repeat.
Comment #8
helmo commentedOr even better... let an admin with the right permissions follow the redirect.
Comment #9
pasqualleIs there any situation when this redirect can cause problems?
Comment #10
helmo commentedI doubt it. It's working fine here. And anyone with the 'access site in maintenance mode' permission should be aware of ongoing maintenance :)
Comment #11
pasqualleI also do not see any problem with this change..
Comment #12
dave reidRe-rolled to move the user_access() check up to the if statement rather than inside of it, so that the additional checks can still execute.
Comment #13
dave reidCommitted #12 to 7.x-1.x.