This is a beginning to cleanup the code.

Since xhprof.inc is included in the module, should we update it for Drupal coding standards?

CommentFileSizeAuthor
#1 XHProf-coding_standards-1444754-1.patch19.57 KBerikwebb

Comments

erikwebb’s picture

erikwebb commented
StatusFileSize
new XHProf-coding_standards-1444754-1.patch19.57 KB
erikwebb’s picture

erikwebb commented
Status: Active » Needs review
msonnabaum’s picture

msonnabaum commented
Status: Needs review » Fixed

I went ahead and took this, but there's no point in trying to clean up xhprof.inc much more. It's mostly just copied from the facebook source and it's no where near our coding standards. It's really just temporary for now, it'll eventually all be replaced by https://github.com/msonnabaum/XHProfLib.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.