Add langcode property in taxonomy schema

This patch adds a language field to the schema, and adds the field to the db in the update hook.

Thanks for the review! Here is the new patch.

+++ b/core/modules/taxonomy/taxonomy.install
@@ -245,4 +252,19 @@ function taxonomy_field_schema($field) {
-}
\ No newline at end of file

hmm... why is the end of the file at middle?

This patch also sets the langcode to LANGUAGE_NONE when saving a new term which doesn't have a langcode.

+++ b/core/modules/taxonomy/taxonomy.installundefined
@@ -39,6 +39,13 @@ function taxonomy_schema() {
+      'langcode' => array(
+      'description' => 'The {language}.langcode of this term.',
+      'type' => 'varchar',
+      'length' => 12,
+      'not null' => TRUE,
+      'default' => '',

The indentation is not right here.

Other than that it looks okay.

+++ b/core/modules/taxonomy/taxonomy.installundefined
@@ -245,4 +252,20 @@ function taxonomy_field_schema($field) {
+  );
+  db_add_field('taxonomy_term_data', 'language', $langcode_field, $keys_new = array());

We probably want to remove the $key_new = array() part there too.

Thanks! I updated the patch.

I corrected the field name in the update hook.

I checked the code and the tests run well, so I change the status to RTBC.

Is it possible to add test coverage for this?

Cool, there's an API-only test class that should work for this. It's named TaxonomyTermUnitTest currently (despite that it actually extends the web test class). (See also: #1446366: [meta] Multiple web test classes mislabeled as unit tests. simpletest ([Web|Unit|DrupalUnit]TestBase))

+++ b/core/modules/taxonomy/taxonomy.install
@@ -245,4 +252,20 @@ function taxonomy_field_schema($field) {
+/**
+ * Add langcode field to the database.
+ */

Clarify which table the field is being added to.

+++ b/core/modules/taxonomy/taxonomy.install
@@ -245,4 +252,20 @@ function taxonomy_field_schema($field) {
+    // Set all existing terms' language to LANGUAGE_NONE.
+    'initial' => LANGUAGE_NONE,

Unnecessary comment.

+++ b/core/modules/taxonomy/taxonomy.module
@@ -620,6 +620,7 @@ function taxonomy_check_vocabulary_hierarchy($vocabulary, $changed_term) {
+ *   - langcode: (optional) The language of the term.

s/language/language code/

+++ b/core/modules/taxonomy/taxonomy.module
@@ -657,6 +658,9 @@ function taxonomy_term_save($term) {
+    if (empty($term->langcode)) {
+      $term->langcode = LANGUAGE_NONE;
+    }

I think this would be better earlier in the function, before the presave hooks are invoked on other modules.

6 days to next Drupal core point release.

This patch addresses #16 and #17. It also adds langcode to {taxonomy_vocabulary}, since vocabularies are also entities, according to taxonomy_entity_info().

I disagree with #14. I added the assertions in #1444992-22: Add langcode property in file schema because there was already a test for file_save() to add them to. However, none of our other entity types have low-level unit tests for saving via the API and verifying that each property got saved correctly. I don't think this is the issue in which to add such low-level unit tests. We may want to do so for all entity types, especially in relation to the Web Services initiative (where all of our entity CRUD needs to be fully decoupled from forms), but I don't think it's needed here. That does mean we don't have test coverage for now for this property, but I'm assuming after this lands, there will be a follow-up issue for moving node.module's UI for langcode to all entity forms, and we can incorporate functional tests there. In the meantime, this issue just lays the groundwork for that work. So, I'm removing the "Needs tests" tag, but please add it back if you disagree with me.

Aye, I'd agree that upgrade path tests are a really good idea any time there's a hook_update_N() in a patch, really.

Merging this into a combined issue in #1454538: Add langcode property to all entity types; for the user entity, distinguish entity language from user's language preference. Will address #20 in that patch.