Just installed External Links and discovered that there are 2 missing lists on the config page for the module. Under the "Pattern Matching" fieldset, it says "Here are some common patterns." and "Common special characters:" but no examples underneath. The lists were missing. Updated the theme('item_list') call to use the 'items' key.
Just a little minor thing but stoked to be submitting my first patch! So please go easy on me! And let me know if there's something I should be doing different.
Thanks,
Mickey
| Comment | File | Size | Author |
|---|---|---|---|
| extlink-theme_item_list.patch | 942 bytes | micnap |
Comments
Comment #1
quicksketchExcellent, thanks for the patch! I'll put it in next time I'm working on External Links.
Comment #2
rbrownell+1
Comment #3
elachlan commented+1 For usability.
Comment #4
elachlan commentedChanging title to be more descriptive.
Comment #5
elachlan commentedCommitted to Git. Needs to be ported to 6.x.
Comment #6
elachlan commentedCommitted to Git.
Comment #7
dianacastillo commentedyour examples are totally wrong! what works is this :
example.com|anotherexample.com
as per http://www.drupalgardens.com/documentation/external-links
the pipe has to be between the domains. can you fix this please
Comment #8
dianacastillo commentedthe examples listed are wrong, the pipe has to be between the domains as per my last post
Comment #9
quicksketchThey're not totally wrong. This is what we have already (with a pipe between domains):
(example\.com)|(example\.net)
This works perfectly fine. Your example actually has an issue in that a period matches *any* character, so it would match things like "examplexcom" (though that's not very likely). Since we're already using a pipe, I don't see that we need to "correct" the patterns, because they're already acceptable. I do think they're awfully hard to read when they're italicized though, perhaps that's the problem? Let's switch these to code tags. I've made a new issue at #2242733: Use code tags for examples instead of em.