Synapse

Hi, welcome with your application.

Are there som similar modules, and why do you combine this functions in the same module?

Here is some manual review:

Project page

Could it be possible to get the project page in English? I guess the target audience for this project is Russian, but I do not think that we have so many reviewers that read Russian, and therefore it would be almost impossible to get somebody reviewing the project page.

README.txt

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

synapse.info

'description = Usefull administration stuff' Does not say so much, please provide a meaningful description in the file

synapse.module

Please remove information about author from file, this you could add to your README.txt

Please make comments in the code in English, and comment the functions more, and in Doxygen-style.

You have commented out css, if you not are going to use it, please remove it from the code.

I think that you should add your css in files instead of inline, and also, if you are going to hide elements with css with your module, tell it on the project page and in the README.txt.

Why are you hiding elements with css?

You have untranslated strings in the javascript that is inserted, you should use t(),

You have a lot of variable_get, but I do not see any variable_set

js/contact.js and js/picker.js

Comments are in Russian, please provide them in english

When I install the module, I get the following notices:

The block Yandex metrics was assigned to the invalid region footer and has been disabled.
The block hCard was assigned to the invalid region footer and has been disabled.
The block CopyRights was assigned to the invalid region footer and has been disabled.

Line 134, synapse.module:

  $blocks['metrika'] = array(
    'info' => 'Yandex metrics',
    'weight' => 100,
    'status' => 1,
    'region' => 'footer',
    'cache' => DRUPAL_CACHE_GLOBAL,
  );

In each of the blocks defined there, the "region" variable is optional. Not knowing whether the theme the user is using has the "footer" region, it's best to leave the "region" variable out, and let the user know they should enable the blocks manually. Probably also best to omit the "status" and "weight" items.

Use a .install file and include the uninstall() hook to make sure all the variables you use are deleted. Something like:

function synapse_uninstall() {
  variable_del('fn_org');
  variable_del('yandex_webmaster_verification');
  // add the remaining variables used in your module
}

Hi,

You can remove blank description from synapse.admin.inc file

'#description' => t(''),

With comment #4 and #5 this should be marked as needs work. I assign it to me so I remember to come back as soon as when you have fixed the issues.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

git.drupal.org