Block visibility didn't used to get inherited at all, but now it's attempting to inherit the block visibility and failing to do so correctly. This patch should correct those problems and allow block visibility to correctly be verified in the panel

CommentFileSizeAuthor
#5 panels.144558.patch2.34 KBbaldwinlouie
panels_block_visibility.patch1.36 KBcsevb10

Comments

emmajane’s picture

emmajane commented

Patch applied, title is still appearing even when the content is (correctly) hidden.

Anonymous’s picture

Anonymous (not verified) commented

This should not use the visibility set in admin/build/block automatically but have an option to either use it from there or supply it (like how titles work).

csevb10’s picture

csevb10 commented

I am willing to accept that as a viable possibility, however, this patch is simply a fix for a bug that exists in current panels code. This fixes the attempted block visibility section that already exists. It could be nice at a later time to have a toggle directly in the panel, BUT everything that can be done with that toggle is doable via the block visibility settings as well.

suzanne.aldrich’s picture

suzanne.aldrich commented

Hi there, this blocks visibility bug is annoying, and the patch didn't seem to help. Subscribing.

baldwinlouie’s picture

baldwinlouie commented
StatusFileSize
new panels.144558.patch2.34 KB

I needed to run this patch on our instance. I seem to have gotten this to work. I also added some code to inherit user permissions from the block.

If anyone is still using the panels 1, here is a patch that I wrote.

Reviews are still appreciated.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Closed (won't fix)

Panels 1 patches are no longer being accepted.