having the system module manage menu blocks seems unintuitive, we have a menu module for that.
Move the this code into the menu module.
// System-defined menu blocks.
foreach (menu_list_system_menus() as $menu_name => $title) {
$blocks[$menu_name]['info'] = t($title);
// Menu blocks can't be cached because each menu item can have
// a custom access callback. menu.inc manages its own caching.
$blocks[$menu_name]['cache'] = DRUPAL_NO_CACHE;
}
#1085692: Make block--menu.tpl.php apply to all menu blocks
#1445596: Add intuitive menu-specific block template theme suggestions
Comments
Comment #1
NealB-1 commentedThe problem is that the menu module is optional and provides the user-defined menus. A fresh Drupal install would be barely usable without at least the navigation block. System is where you generally find the absolute basics that give you a useful install.
menu_list_system_menus() should perhaps be made into a hook, though. Since menus are identified by their machine names, and not a key generated by the database, something like a hook_default_menus() would enable additional menus to be provided by modules entirely in code. This is already technically possible, but the menu module will not be aware of the menu unless it's also added to the menu_custom table.
Comment #1.0
NealB-1 commentedtypo
Comment #2
jp.stacey commentedAdding tags as per related issue #1445596: Add intuitive menu-specific block template theme suggestions as they potentially affect this issue too.
Comment #3
jenlampton@NealB I disagree. If you want something thats a collection of other things, what you want is an install profile. Menu blocks (and default menus) should be provided by menu module. If you are just using system but not menu, then you can build your own navigation in other ways.
Here's the Backdrop equivilent issue: https://github.com/backdrop/backdrop-issues/issues/198
Comment #17
smustgrave commentedThank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Comment #18
smustgrave commentedSince there's been no follow up in 3 months going to close out, but this can always be re-opened.
Thanks all!