Did some permissions/text work, here's the patch. [#144562]

Ok, I've attached a patch to alinks.module. It doesn't fix any of my other small gripes, but I have done the following in the patch. Whether or not anyone agrees, it's here now, for me to find that out...

I have tidied up the English in the included text for legibility and usability (fixed typos & now with "more help")
I've added a permission "edit alinks" so that roles do not have to have the "administer site configuration" permission

I added the permission because I have a site with a very simple interface on the back-end, and I didn't want to complicate the administration for the site manager by having to enable config admin. Having to give the site manager "administer site configuration" allows him to disable modules and all sorts of things he shouldn't have access to. This gets round that problem - the "alinks" edit menu will simply appear in the Navigation block of any user in the role with the new permission granted to them.

Comment	File	Size	Author
	alinks.module_1.patch	4.13 KB	niklp

Comments

Comment #1

tic2000 commented 16 May 2007 at 20:17

Thanks for this patch. I will apply this patch and will be in the next release.

Comment #2

niklp commented 16 May 2007 at 20:28

There's a caveat here - just spotted it.

If you use internal links in the format I have suggested in the patch, it will break.

It is necessary to update line 125 to start: $alink_url[] = '

The base_path will stop internal links breaking. This will stop external links working, however.

I suggest the addition of a checkbox for each alink to say "External link?" and then not add the base_path in this case.

Sorry for the confusion.

Comment #3

niklp commented 16 May 2007 at 20:33

GAH! Sorry.

$alink_url[] = '<a href="' . base_path() . check_url($word['alink_url'])

This will make internal links work, but break external links - I'm not using external links right now, so I don't care! :p I suggest, however, the addition of a checkbox (per alink) to select if it is an external link. This is the only way I can think of that the internal links will be saved.