Closed (fixed)
Project:
Zen
Version:
7.x-5.1
Component:
CSS/SASS/HTML markup
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
19 Feb 2012 at 20:43 UTC
Updated:
10 Aug 2012 at 12:00 UTC
STARTERKIT’s tabs.css is not a compile of the current tabs.scss.
It probably happened during your find and replace for IE classes which turns out this file doesn’t use since changing to use the Compass clearfix.
Comments
Comment #1
johnalbinThanks for noticing that, Elly!
Ok. So I originally thought we could "easily" keep track of changes made to the Sass files and copy them to the CSS files.
But I can see it is too easy to let the CSS code base drift from the Sass code base. :-(
I remember that Chris Epstein pointed out that
/* */comments get stripped out when usingoutput_style = :compressedon production sites, but not whenoutput_style = :expanded or :nested or :compacton development sites.So I did an experiment. What if we converted our Sass comments back to
/* */ones and then compile them withoutput_style = :expandedand save those CSS files in our git repository?This is what I discovered:
git diffand relatively easily restore items #1-3 before committing the newly compiled CSS.So, I think we should go ahead and make the CSS files be slightly-modified compiled versions of the Sass files.
Comment #2
johnalbinFixed. http://drupalcode.org/project/zen.git/commitdiff/fb41a5d?hp=8d71f64196af...
Comment #4
mustanggb commentedThe SASS doesn't want to compile to the current CSS.
For example currently in blocks.css there is this:
However with :expanded the SASS becomes:
With :nested the SASS becomes:
With :compact the SASS becomes:
With :compressed the SASS becomes:
As you can see none of these are identical to the current CSS.
Comment #5
johnalbinYep. Re-read my comment in #1 above. In particular the last line:
The only reason why I go through this trouble is I would like people to use Zen even if they aren't yet ready to make the Sass plunge.
BTW, I also turn on IE6 and IE7 support before I compile the CSS. But then leave those variables off for the Sass files.
Comment #6
mustanggb commentedYes, I did notice this :)
I guess this is by design then. In which case perhaps you could confirm which of the following is true. Current CSS is almost the same as :expanded so did you:
a) Manually go through and remove the extra line breaks for comments
b) Set extra sass options or use a different environment value that I have been unable to determine that adds additional whitespace
If (b) could you share the additional knowledge please.