Fix external links

(correcting title, I hope)

Just because you ask Drupal to slap $base_path onto your Drupal path you surely still want to do language URL rewrites. What you do not want to rewrite is an external URL thrown at url().

THe second chunk was not needed.

Yes, it seems like it was broken to check for the absolute flag, because there people ask url() to output an absolute URL. It does not say, that the actual "path" passed in was "absolute" = external. This surely needs to be tested with combinations of omitted language codes, domain name based setups, path prefix based setups and the like. In principal it looks like, so if testing shows this is finally right, then it is fine with me.

yched: can you test?

menu_path_is_external is not particularly fast and calling this for every url() is NOT a good idea. We should add an 'external' flag in addition to the 'absolute' flag. All too often, people think that absolute == external.

Refactored. We already determine whether an URL is external or not, now that is called early and language_url_rewrite checks for that. I marked RTBC as there is no functionality change compared to the previous patch.

- Is it a good idea to allow bypassing filter_xss_bad_protocol() by providing the external flag from outside? I'd say that this code was there, so we can just use it as an internal check. (For security's shake)
- The first documentation line you added is badly indented.

fxbp is only used for checking. security measures are taken by l in the form of a check_url. Spaces fixed.

Patch looks good.

$ grep -r "http://" * | grep " l(" | grep -v @
modules/openid/openid.module:      '#description' => l(t('What is OpenID?'), 'http://openid.net/', array('external' => TRUE))
modules/syslog/syslog.module:      '!php'         => l("PHP's syslog", 'http://www.php.net/manual/en/function.openlog.php'),
modules/syslog/syslog.module:      '!syslog_conf' => l('UNIX/Linux syslog.conf', 'http://www.rt.com/man/syslog.5.html'),

Oddly enough, the OpenID link already used 'external'? Also, should we add an external attribute to the php and syslog_conf links?

can we do that in a followup patch and get this in? :)

I committed this patch, and changed the subject. Thanks for your help, chx.

Dries committed the patch.

Followup patch as agreed above.

Great, committed.