Hi, I'm doing some install profile work and trying to figure out a way to make my system easiest to upgrade, and it works much easier if the location of the getid3 lib is user assignable. For example, I try to keep all non-core files to either sites/all, sites/site.domain, or in profiles/profilename. (places where they don't get mixed with core files, such as in /misc.

I've tested the patch and unless the settings are changed at the admin page, it works exactly as it did previously.

-Mike

CommentFileSizeAuthor
#3 mediafield.getid3_.patch3.45 KBrobloach
mediafield_0.patch2.12 KBmikey_p

Comments

ardas’s picture

ardas commented
Assigned: Unassigned » ardas

I will review and commit your patch shortly. It looks good at the first site. No problems to have such option.
There were many requests from people who had troubles with locations... which is strange, I thought misc/lib is a good option because Drupal has no special directory for 3d party components so misc/lib looked a good one.

robloach’s picture

robloach
he/him
commented

I just contributed the getID3() module, which provides an API to facilitate an installation of getID3. MediaField should move to start using this instead of just assuming that getID3 is installed in drupal/misc/lib/getid3.

The benefits to using this getID3 module is that it abstracts the getID3 functionality away from MediaField, making it accessible by other modules. It also gives additional functionality, including a requirements warning in admin/logs/status when getID3 is not installed, an easy way to include getID3 in other modules via a single call to getid3_load, and (eventually) the ability for the user to change the location where getID3 is installed.

This API is still young, so some additional functionality will become available in the future. I'll send in a patch to MediaField in the next two days which will use this instead of its assuming getID3 is installed in 'misc/lib/getid3'.

robloach’s picture

robloach
he/him
commented
Title: Make getid3 lib location user assignable » Make getID3() library location user assignable
StatusFileSize
new mediafield.getid3_.patch3.45 KB

This patch will make MediaField use the getID3 Drupal API Module instead of assuming getID3 is installed in drupal/misc/lib/getid3.

robloach’s picture

robloach
he/him
commented
Priority: Normal » Critical
a_c_m’s picture

a_c_m commented
Status: Needs review » Needs work

Committed to HEAD (http://drupal.org/cvs?commit=123615) with changes due to bug in getId3 see http://drupal.org/node/275151 for details.

a_c_m’s picture

a_c_m commented
Assigned: ardas » Unassigned
Priority: Critical » Normal
a_c_m’s picture

a_c_m commented
Status: Needs work » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.