Drupal caching causes random breaking of Superfish menus

Hey Andy,

Try the v1.9-beta4 please.

Email me the URL please.

Have the same problem for a long time, superfish is the module that has 4 blocks on my page (3 of them inside tabs in QuickTabs module, but it doesn't change anything as I did some testing), when they are not cached the page performance is very low...

So basically I hardcoded CSS files to the theme and just gave each superfish menu proper ul class so I could get around the CSS caching issue, but still .js files are not working when the superfish blocks are being cached, so my menus have no delay, no arrows etc..

you can check it here http://new.quantum.com.pl/en/about-us - you have the main top menu in superfish, and then on the left you have quicktabs (categories/manufacturers/applications) and the menus there are superfish as well.

I can confirm the same problem

Also getting this warning in my watchdog

a:6:{s:5:"%type";s:7:"Warning";s:8:"!message";s:182:"file_get_contents(/sites/all/libraries/superfish/superfish.js) [function.file-get-contents]: failed to open stream: No such file or directory";s:9:"%function";s:23:"drupal_build_js_cache()";s:5:"%file";s:72:"docroot/includes/common.inc";s:5:"%line";i:4817;s:14:"severity_level";i:4;}

In my instance, it was caused by a dodgey drupal_add_js line that was handing

      drupal_add_js(base_path() . $path . '/superfish.js');

    if ($path = libraries_get_path('superfish')) {
      drupal_add_js($path . '/superfish.js');
   }

never hand full paths to drupal_add_js() :)

check your watchdog for warnings, that will rule out drupal_add_js failling

when it does fail, let us know if you see the superfish in the aggregated JS by grepping it

I don't have any warnings, what is more in Chrome Dev Tools I see all superfish.js files as loaded (http://new.quantum.com.pl/) but still you can see the main menu (navy one with yellow hover) in superfish doesn't load superfish.js file (no delay, cannot size subs in settings...)... There is even no default 600ms working, why is that? :(

is there another javascript error occuring?

the menu there works for me in chrome

No, but know I found that entry similar to yours, but its just one warning, not showing again after clearing cache, after I cc one page load is perfect, all js working, then next (cached ones) break... and there is no warning now at all..

Yes, menu works, but I cannot set delay options, there are no arrow for submenus loaded etc... I cannot set supersubs size,
When i switch off cache on superfish menu block it all works without any changes, 600ms delay, supersubs bigger size etc

This is my init where .js are loaded, maybe it's because of Libraries module? Any tips what should I change I dont see base_path() anywhere like you wrote in #8

function superfish_init() {
  if (module_exists('libraries')) {
    $sf_library = variable_get('superfish_slp',
      libraries_get_path('superfish') . "/jquery.hoverIntent.minified.js\n" .
      libraries_get_path('superfish') . "/jquery.bgiframe.min.js\n" .
      libraries_get_path('superfish') . "/superfish.js\n" .
      libraries_get_path('superfish') . "/supersubs.js\n" .
      libraries_get_path('superfish') . "/supposition.js\n" .
      libraries_get_path('superfish') . "/sftouchscreen.js");
    $sf_library = preg_replace("/(^[\r\n]*|[\r\n]+)[\s\t]*[\r\n]+/", "\n", trim($sf_library));
    $sf_library = explode("\n", $sf_library);
    foreach ($sf_library as $s) {
      drupal_add_js($s, 'file');
    }
    
    drupal_add_js(drupal_get_path('module', 'superfish') . '/superfish.js', 'file');

    drupal_add_css(libraries_get_path('superfish') . '/css/superfish.css', 'file');
    drupal_add_css(libraries_get_path('superfish') . '/css/superfish-vertical.css', 'file');
    drupal_add_css(libraries_get_path('superfish') . '/css/superfish-navbar.css', 'file');
  }
}

I see all the superfish.js and other files loaded in Chrome Inspector, they are just not "being used"... Don't know what is going on...

unsure, but i've never seen someone use variable_get like that!

it's the genuine superfish module superfish.module file, I didn't change anything...

I noticed that when superfish block is cached there are 3 classes missing from ul element:

MENU NOT WORKING:
class="menu sf-menu sf-main-menu sf-horizontal sf-style-none sf-total-items-7 sf-parent-items-2 sf-single-items-5 quantum-superfish-mainmenu"

MENU WORKING:
class="menu sf-menu sf-main-menu sf-horizontal sf-style-none sf-total-items-7 sf-parent-items-2 sf-single-items-5 quantum-superfish-mainmenu superfish-processed sf-js-enabled sf-shadow"

I forced adding these classes through superfish block settings (applying them to the ul), but that doesn't help... So JavaScript files are being loaded, after clear cache first page load shows everything correctly, then it breaks as page is cached and no delay shadow supersubs options are working...

hack the superfish code and remove the caching just to see if that fixes your problem, if it does, let us know

I'm having this exact problem

#withdrawn#

I have also encountered this issue.

It turns out that hook_init() performs setup tasks for non-cached page requests..

So one solution I can imagine is implementing hook_libraires_info() rather than hook_init(). Then using libraries_load() to load superfish js files in the superfish_content().

By doing this we can also gain another benefit that superfish library will be only loaded when superfish blocks show up, not for every page. For example admin pages.

Hey Eric,

Are you sure you're using the latest development release?

Hello,
The random breaking of Superfish menus could also be because of the jQuery Update module.
Disable the module (if installed) & check again.

Thanking you,

Regards,
Supriya Rajgopal

I'm facing a similar problem. When I use AdvAgg to minify and unify JS/CSS files, the menu sometimes need a page refresh to update the mobile view (hamburger icon). Desktop version it shows some miliseconds and I think that could be better hiding the rendering of that menu on mobile view.

Maybe there is some workaround for this issue?

EDIT: I'm in D8, lastest dev version.

renguer0 please looking for this problem in current issues, if it doesn't exist, create new one for 8.x branch