According to Drupal coding standards - and indeed what we're doing in new project application reviews - function documentation should include parameter and return types. See Data types on param/return at http://drupal.org/node/1354.

CommentFileSizeAuthor
#1 signup-document-data-types-1447598-1.patch39.07 KBjordojuice

Comments

jordojuice’s picture

jordojuice commented
Status: Active » Needs review
StatusFileSize
new signup-document-data-types-1447598-1.patch39.07 KB

This patch adds data types to all comments and fixes some comments. No actual code is touched.

jerenus’s picture

jerenus commented
Status: Needs review » Reviewed & tested by the community

Like your patch. Good work.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

Yup, looks good, thanks! Pushed to 7.x-1.x:

http://drupalcode.org/project/signup.git/commit/b9c4663a892bf69cb5a8ddcd...

Cheers,
-Derek

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.