Organization Structure

A quick review after checking your repository:

1. You are working on master branch. You should use feature branch: 6.x-1.x. See http://drupal.org/node/1127732
2. The ; $Id$ is not necessary, this was used for old cvs system in dorg.
3. I'm not sure, but imho files[] = organization_structure.module doesn't need, especially in drupal 6. All .module file of enabled modules are included during the drupal bootstrap process.
4. I don't know what your module will do exactly, but in schema, there isn't any index defined. I ask: Won't this cause performance issue?
5. You use some SELECT query on functions, but no static cache used.
6. 'file' => 'organization_structure.module' on organization_structure_menu no need, if the menu callback is on the same module file.

And a question too:
You defined "admin/orgstructure/%". Then you build an organization structure object. Won't be better admin/orgstructure/%org, like node/%node on node.pages.inc? (This need some other change, eg. need to write own _load function, so this is really question, not a 'musthave' thing..)

At the end, you should check the coding standards, see http://ventral.org/pareview/httpgitdrupalorgsandboxvikramaditya234144639...

Hello, first off used the online auto scanner. Found only a trivial coding style issue, not a problem. These are included in the attached file. Feel free to run the scanner yourself to resolve these issues.

For Drupal coding conventions please refer to:
http://drupal.org/coding-standards#comment
http://drupal.org/node/1354

The more main issue is that you need to setup master to just have README. Backing up everything is wise before you do this of course. See:
http://drupal.org/node/1127732

The project page:
http://drupal.org/sandbox/vikramaditya234/1446396
could use some better description and documentation, and/or make a separate documentation page.

Should be pretty close after the branch move and a few fixes.

do NOT wrap text in hook_menu funktions with t()!

@darrellulm
please be more carefull with your copy/pasting
he was already instructed to pareview and and coding standarts -> he already moved into a version specific branch
for simple modules that can be installed just as any other, there is absolutely no need for a install.txt

such reviews won't be accepted for review bonus

setting back to needs review, as there are only minor issues

@patrickd OK, before I think the MASTER was supposed to be empty with a README file only. Good to know this has changed and MASTER can be used again as HEAD, and thanks for the new information.

.. the master should be empty but you wanted him to move to a version specific branch what he already did..

back to topic now

Closing due to lack of activity. Feel free to reopen if you are still working on this application.