I've disabled the default favicon und used the setting "favicon_path" to define an icon. My path in the settings is now "sites/all/themes/custom/favicon.ico".

Debugging the module code, I noticed that something is returning my settings wrong.

$favicon = theme_get_setting('favicon_path');

This line always has a value which is an empty string.

Attached is a version which fixes the problem for my installation.

CommentFileSizeAuthor
favicon.zip7.67 KBLeisureLarry

Comments

johnennew’s picture

johnennew commented
Status: Active » Closed (cannot reproduce)

Please submit fixes as patch files rather than zips as it greatly helps module maintainers!

What theme are you using that doesn't put theme settings in a standard place?
Have you followed the configuration instructions in the readme file?

With latest 7.x-1.x code, I put a favicon in my theme, set the path as you suggest in the theme settings page and tested and /favicon.ico returns the correct favicon.

Closing this issue as cannot reproduce but do repoen if you can provide any additional details.

johnennew’s picture

johnennew commented
Issue summary: View changes

Security-Fix