Download & Extend
AuctionAds Integration » Issues

ehm...Ads size/format isn't shown correctly. Default value is fixed.

Posted by psicomante on May 17, 2007 at 8:20pm
Project:AuctionAds Integration
Version:5.x-2.0
Component:Code
Category:bug report
Priority:critical
Assigned:yaph
Status:closed (fixed)

Issue Summary

In these lines, size values aren't get by variables, but are hardcoded.

<?php
auctionads_ad_campaign = "";
auctionads_ad_width = "468";
auctionads_ad_height = "60";
auctionads_ad_kw = "$ad_kw";
?>

Strange bug huh? :)

Login or register to post comments

Comments

#1

Posted by recruiterjoe on May 17, 2007 at 9:21pm

Replace the hard coding of the width and height with $width and $height which are defined ~ line 209...

#2

Posted by psicomante on May 18, 2007 at 8:42am

Yes i did for my site. But why not to commit a patch?

#3

Posted by psicomante on May 18, 2007 at 8:56am

Sorry, i didn't want to be annoying. My question is if why leave a module not configurable?

#4

Posted by yaph on May 19, 2007 at 7:52am
Assigned to:Anonymous» yaph
Status:active» closed (fixed)

I Fixed this bug replacing the hard coded values for width and height with the correct variables. Thanks for your report.