Currently the formatter always shows the jplayer even there are no files uploaded.

CommentFileSizeAuthor
#2 1448202-jplayer-empty-files-hide.patch1.12 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review

This patch works perfectly for me, though i'm not sure whether checking for !empty is the right approach, but the array is always just array(), so it works for me.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 1448202-jplayer-empty-files-hide.patch1.12 KB

*facepalm*

This time with the actual patch

jamescook’s picture

jamescook commented

seems to work fine - thanks

deviantintegral’s picture

deviantintegral commented
Status: Needs review » Closed (duplicate)

I committed a similar patch over at #1388882: Formatter should skip display of the player when there are no files. Note that you have to return an empty array otherwise a field label will still show.