Closed (fixed)
Project:
OG Forum
Version:
5.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Reporter:
Created:
17 May 2007 at 21:07 UTC
Updated:
9 Jul 2007 at 19:02 UTC
Jump to comment: Most recent file
I know there are a couple of other tickets in regards to this issue and I have applied the recommended patches, but this problem persists. The OG Forum seems to either ignore or not understand there are forum containers available.
Am I missing something? The latest version of the module has been installed but even with the patches floating around, nothing seems to work regardless. Is there a functionality patch I am missing?
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | Picture 1_2.jpg | 41.07 KB | jhm |
| #3 | og_forum_7.patch | 35.93 KB | jhm |
Comments
Comment #1
jhm commentedI have the same problem and it took me the entire day to track it down to OG Forum. I think it is a NULL join with og_types or something. I will post a fix soon (I hope).
Comment #2
shane birley commentedCool!
Comment #3
jhm commentedHere is a patch that includes a fix which shows the Forum drop-down menu populated again and also allows to specify a container per og type to create the the og_forums in.
Comment #4
shane birley commentedThe patch went in great! There is now a problem where the forums are not being created by the module. I am not entirely sure if this is related to your patch but will do a bit more testing on it.
Comment #5
jhm commentedHave you created a parent container? It needs to be a container, not a forum. Then go to admin/og/og_forum and check if you have selected -NONE- for your group type.
Comment #6
shane birley commentedI cleared all of the forums (this is just a test site) and created a single forum to test and see if the module would create the appropriate forums and it failed to do so.
Comment #7
shane birley commentedSorry, not a forum, I created a single container in which I wanted the private forums, but it didn't create any.
Comment #8
shane birley commentedI have gone over the installation a few times now and have no explanation as to why the OG_forum module is not creating the modules. Hmmm. Anything I can check for you? I am at a bit of a loss at this point.
Comment #9
jhm commentedtry and truncate og_term in the database.
Comment #10
shane birley commentedNo effect. I am going to drop all of the og tables and do a fresh install of OG later today. Will let you know how this goes.
Comment #11
jhm commentedIn the og_forum.module nodeapi hook it checks for a variable to be > 0
can you check in your database if any of those variables are set?
SELECT * FROM variable WHERE name LIKE 'og_%_container'If that comes back empty, we know why nothing is being created.
Comment #12
Matthew OMalley commentedThis is the same issue I'm having - the og_forum module no longer creates a new forum when a new group is created. I've run the SQL query and do not have any variables that match that in the database. Where in the code is that variable supposed to be created? I can't find any reference to it other than the check for it.
Comment #13
jhm commentedAssuming that you have successfully applied the patch I posted here, there is a line in the code that checks for a variable named
og_{node->type}_container
if none of those variables exist, that means you either didn't apply the patch or never visited the
admin/og/og_forum
page and saved the admin settings. On that page you should be able to select a default container per og node type. I attached a screenshot of what admin/og/og_forum looks like on my test system
Comment #14
terrybritton commentedjhm - I installed the patch and it solved the issues with forum taxonomy not being populated. I also really like the containers for group forums. What does it take to get this rolled into the module? Especially since there are about five posts on the exact same issue.
Comment #15
terrybritton commentedp.s. - I did not have any problems with og forums being created for new groups.
Comment #16
jhm commentedI don't know.
Comment #17
mightyiam commentedCould this be the reason why:
using firefox, in the create forum topic form, there are no forums to choose from? This is while using Konqueror, there is no such problem.
If not, does anyone have a direction on this? I don't code.
Comment #18
CheckeredFlag commentedThis patch submitted by jhm fixed the dropdown menu population issue for me.
jhm, with regard to the "specify a container per og type to create the the og_forums in", I'm not sure what this means nor what behavior was modified. Does this mean that the user must select the forum in which to create a topic? I wish there were an option to suppress this so that users are not confused by this - even though it defaults to the current forum. Is this a separate issue?
Anyway, I too would like to see the dropdown menu fix incorporated.
Comment #19
rconstantine commentedCould someone check version 2.x and see if I need to look at adding this patch to it? Also, see the ANNOUNCEMENT issue.
Comment #20
CheckeredFlag commentedI couldn't find a 2.x version tarball and since I'm not too sure what I'm doing in CVS, I'm not sure I did this right. Assuming it's the files from branch DRUPAL-5--2, then yes, the issue remains and this patch is still needed.
Hope this helps and thanks for taking over the maintenance.
Comment #21
rconstantine commentedAdjusted version of issue to 2.x
Comment #22
rconstantine commentedWait a minute. I just checked and I don't see this problem.
I'm unclear as to the original post's meaning, but from what I see in #13, the patch seems to be addressing a separate issue. If the original post is talking about selecting which forum to place a new topic into, that works just fine already. In regular operation, if the user is creating a topic from within an OG, then the drop down selector will default to the forum/subforum in which they were browsing at the time. To elaborate:
Given this forum structure where SW =site-wide, G=group, C=container (as defined by the regular forum module), F=forum, and T=topic...
SW
-C1
--F1
---T1
---T2
--F2
---T1
-C2
--F1
--F2
---T1
---T2
---T3
G1
-C1
--F1
---T1
G2
-C1
--F1
---T1
--F2
---T1
-C2
--F1
1) Then, if I'm not in a forum, I'll have a drop down, but no default. The list will be restricted to groups I belong to, plus all under SW.
2) If I'm in SW->C1, then that will be the default. The drop down will show the same restricted list.
3) if I'm in SW->C2->F2, then that will be the default.
4) If I'm looking at G2->C1->F1->T1, then the default will be G2->C1->F1.
And so on. So I don't see why there is a need for the extra selector at admin/og/og_forum. This patch seems to create a willy-nilly (admin's whim) default selection that isn't based on where a user is in the forums, but rather on what content type the group was created from. It also seems that the chosen default container for each group content type is actually in the SW forums, and not really within a group forum. Am I misunderstanding this? It seems that this patch is trying to allow manual controls for what was already an automatic process. What this sound like to me, is more of a group-of-groups module, where associated groups (in this case, those that share a common content type) SHARE a single forum, rather than have their own. If I'm not understanding this, please explain.
As for #14, I don't see a problem with taxonomy being populated either. I also do not have problems with forums being created for new groups.
So this seems like more of a feature request to me. I'm changing the category to reflect that. If someone can explain otherwise, I'll be happy to relook at this.
Oh, and by the way, this patch was horribly structured. Basically, the first half consists of the entire module being subtracted, and the second half is the entire modified module being added. Not a good way to do things as nobody reading it can tell what actually changed without scrolling up and down and up and down and ...
Comment #23
rconstantine commentedBy the way, I just wanted to add that I can understand if people don't like the way I handle the drop down when posting new topics from within groups. See the collapsed fieldset called 'Forum context'. I'm open to making this functionality optional. Start a new feature request if that's what you'd like to see.
Comment #24
CheckeredFlag commentedUsing your example, the problem I have is this:
If I am in G1 and I post a new topic, my forum pulldown menu is correct.
However, if I am currently in a deeper location such as G1>F2, my forum pulldown menu only has the default "General discussion" forum for each group and does NOT include the current forum.
The patch fixed this issue for me that is not addressed by 5.x-2.x-dev.
Comment #25
rconstantine commentedI'm really surprised you still see the wrong behavior. I have forums in and out of groups up to six levels deep and the correct forum is selected every time. Other users have verified that the correct behavior is working for them. Please report which version of the module file you are using (it's listed at the top of the file if you open it).
The correct version is 1.11.2.11.2.1 and was upload on the 2nd of July and is in the latest tarball.
Comment #26
CheckeredFlag commentedAhhh...it's fixed! Sorry, I didn't realize a new version had been released since June 29, which is the one I had problems with. Thanks for your work!
Comment #27
darren ohComment #28
rconstantine commented