Closed (fixed)
Project:
VoIP Node
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
21 Feb 2012 at 18:25 UTC
Updated:
28 Feb 2012 at 18:52 UTC
Jump to comment: Most recent file
The default script is set for all extensions as presently required by voipextension. If the default changes it means the old default must be changed on all previous extensions.
Feature: register a 'default'. This can be set for all nodes using the default, hence calling the current default.
Related: the options offered for the script on the extension will still show the existing script even if this script has been removed from the options.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1448450-03.voipnode-extension-default.patch | 8.61 KB | ekes |
| #1 | 1448450-01.voipnode-extension-default.patch | 8.63 KB | ekes |
Comments
Comment #1
ekes commentedSlightly cumbersome logic in the function to retrieve the default.
Comment #2
leoburd commentedI'm not sure this patch is fixing the problem.
The first time we create an instance c1 of a content type C, c1's script name gets initialized with "Default". That seems to be the correct behavior.
However, if we change C's default script name and create a new instance c2, c2's script name ends up being initialized w/ C's new script name instead of "Default".
In my opinion, c2's script name should always be initialized to "Default" no matter what. Isn't that so?
BTW, wouldn't it be better to rename "Default" for something like "Content default"?
Comment #3
ekes commentedUpdated patch to correct node submit form default.
Not sure about changing the name of the default in the node submit form drop down though. The name on the admin node content type form is 'Site default', which is what it is. For the user I don't think it's either necessary to know what the default is, it's just the default; and depending on the content type setting it could be the specific 'content default' or it could be the 'site default'.
Comment #4
leoburd commentedPatch incorporated into 6.x-1.x. Thanks!