The attached patch contains various code reformatting tasks, the largest of them bringing the admin settings form into a better formatted block of code, to increase legibility for maintainers.

CommentFileSizeAuthor
cas_code_reformat.txt12.31 KBjrbeeman

Comments

metzlerd’s picture

Jeff,

Could I ask you to reroll this from head. there were some other changes that I committed, and this patch no longer applies. I'll put in the code reformatting and default roll patch together if you like. The other patches, I'd like to talk strategy with you a bit. I think we need to try and keep the cas settings page managable.

Don't you typically put the account registration pages on your CAS login screen? Or is this registration about something different than CAS. I'd like to facilitate a "request access to this site", rather than an account registratioin page, but perhaps this is done with something besides hook_form_alter which seems an odd way to tackle redirection issues.

Dave

metzlerd’s picture

Status: Active » Needs work

This is good code, but needs to be re-rolled from head.

metzlerd’s picture

Assigned: jrbeeman » metzlerd
Status: Needs work » Fixed

I did the refomatting manually. So this should be done.

Anonymous’s picture

Status: Fixed » Closed (fixed)