Cde style does not comply to Drupal's code style.
That would not be bad, if it was done consisntently. The feedparser mixes averything: one place has } else { another place splits it over two lines. Tabs and spaces are mixed up completely. etcetera.

This patch cleans out all that. Markin RTBC because it changes no logic.

CommentFileSizeAuthor
#1 feedparser_general_style_cleaning_0.patch21.81 KBBèr Kessels
feedparser_general_style_cleaning.patch22.02 KBBèr Kessels

Comments

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new feedparser_general_style_cleaning_0.patch21.81 KB

Removed a left over queryd

budda’s picture

budda
Primary language English
Location Cheshire
commented
Category: bug » task

Thanks for taking the time to put this patch together.
I just attempted to apply it but it's coughing up failures against feedaggregator_node.module,v 1.42.4.2 2007/05/04 01:23:18

patching file feedaggregator_node.module
Hunk #1 FAILED at 9.
Hunk #2 FAILED at 16.
Hunk #3 FAILED at 138.
Hunk #4 FAILED at 150.
Hunk #5 FAILED at 162.
Hunk #6 FAILED at 282.
6 out of 6 hunks FAILED -- saving rejects to file feedaggregator_node.module.rej
patching file feedmanager.module
Hunk #1 FAILED at 88.
Hunk #2 FAILED at 166.
Hunk #3 FAILED at 384.
Hunk #4 FAILED at 418.
Hunk #5 FAILED at 525.
Hunk #6 FAILED at 539.
Hunk #7 FAILED at 592.
patch: **** malformed patch at line 394: @@ -754,7 +758,8 @@
Bèr Kessels’s picture

Bèr Kessels commented
Status: Reviewed & tested by the community » Needs work