I see ie6.css and ie7.css files in the theme, but I don't see how they are loaded? Are they? If so, what is the mechanism?

Comments

adrinux’s picture

adrinux commented

Doesn't look like they are loaded. ie6.scss can probably be retired. ie7.scss content ought to be merged in with the other sass. It's really not in keeping with the 'use a body class for ie specific styles' method of HTML5 Boilerplate.

I'm guessing this is mostly just a hangover from the zen/boron/boilerplate munging that was done to build this theme.

adrinux’s picture

adrinux commented

Just noticed the readme.txt mentions using these stylesheets for 'debugging' IE. I can see it might be useful to have separate stylesheets for that while you're working on fixing IE issues. But there ought to be some commented out code in template.php to include them perhaps? My comment about moving the styles within them and ditching the ie6 one still stand however.

jstoller’s picture

jstoller
he/him
commented

It seems to me that either the theme should support IE, or it should not. Including IE styles in a starter theme that aren't loaded, with no indication how or why they should be loaded, doesn't seem particularly useful.

If the code is worth having, then why not include it in the other exiting partials, or turn these files into their own partials? Then people who don't want IE support can simply remove the files and recompile the CSS.

danlinn’s picture

danlinn commented

Whoa there. The comment about munging was spot on. It was simply omitted. I'll have them included in the next release.

danlinn’s picture

danlinn commented
Status: Active » Needs work
jstoller’s picture

jstoller
he/him
commented
Status: Needs work » Closed (fixed)

Fixed in #1455566: Clean and refactor Boilerplate Sass.