Example HTML title and H1 produced by the diff module on pages like /node/190/revisions

<title>Revisions for Charlie&amp;#039;s Test Project1 | Example.com</title>
<h1 class="title" id="page-title">Revisions for Charlie&amp;#039;s Test Project1</h1>

Note the double encoding. Diff should follow core, for node.pages.inc line 501:

drupal_set_title(t('Revisions for %title', array('%title' => $node->title)), PASS_THROUGH);

I propose a patch so diff does the same, on diff.pages.inc line 23:

drupal_set_title(t('Revisions for %title', array('%title' => $node->title)), PASS_THROUGH);

Fixes all our issues quite nicely, can role a patch if you really want, but this is a one liner that has already been extensively tested (it is in core currently)

CommentFileSizeAuthor
#1 1449722-remove-double-encode.patch631 byteswiifm

Comments

wiifm’s picture

StatusFileSize
new631 bytes

heh, patch rolled in any case against 7.x-2.x-dev

wiifm’s picture

Status: Active » Needs review

change status

halcyonCorsair’s picture

Status: Needs review » Reviewed & tested by the community

Confirm, already sanitized thanks to t(), so drupal_set_title() can safely PASS_THROUGH.

realityloop’s picture

Status: Reviewed & tested by the community » Fixed

committed to 2.x, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.