Closed (fixed)
Project:
Diff
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Feb 2012 at 03:59 UTC
Updated:
20 Jul 2012 at 11:21 UTC
Jump to comment: Most recent file
Example HTML title and H1 produced by the diff module on pages like /node/190/revisions
<title>Revisions for Charlie&#039;s Test Project1 | Example.com</title>
<h1 class="title" id="page-title">Revisions for Charlie&#039;s Test Project1</h1>
Note the double encoding. Diff should follow core, for node.pages.inc line 501:
drupal_set_title(t('Revisions for %title', array('%title' => $node->title)), PASS_THROUGH);
I propose a patch so diff does the same, on diff.pages.inc line 23:
drupal_set_title(t('Revisions for %title', array('%title' => $node->title)), PASS_THROUGH);
Fixes all our issues quite nicely, can role a patch if you really want, but this is a one liner that has already been extensively tested (it is in core currently)
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1449722-remove-double-encode.patch | 631 bytes | wiifm |
Comments
Comment #1
wiifmheh, patch rolled in any case against 7.x-2.x-dev
Comment #2
wiifmchange status
Comment #3
halcyonCorsair commentedConfirm, already sanitized thanks to t(), so drupal_set_title() can safely PASS_THROUGH.
Comment #4
realityloop commentedcommitted to 2.x, thanks.