Needs review
Project:
Connector
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
22 Feb 2012 at 16:01 UTC
Updated:
19 Nov 2014 at 00:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
matglas86 commentedComment #2
frans commentedWhy do you force the field type to be a texfield?
$form['account'][$sync_with]['#type'] == 'textfield'The value is probably text, but the field can be a textarea, checkboxes or even a list (think 'gender' for example).
I do think it can be complicated, so I agree with the alter functions you introduce, but I think that the forced field type has to go. The detection on the 'value' key was not perfect either, but left room for all kinds of field types.
Comment #3
matglas86 commentedSo this needs work? Will do that... patch will come.
Comment #4
frans commentedDid a first fix on this.
I changed the alters to one alter call at the end of the function. I don't see why 2 alters for each field is needed (resources).
It is far from complete, but does its job already a lot better.
See also #1481574: Integration with feeds for some new insights.
Comment #5
dxxNo problems to report.
+1 for add the hook at the end.