Closed (fixed)
Project:
Update Status
Version:
5.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
18 May 2007 at 19:01 UTC
Updated:
5 Jun 2007 at 22:17 UTC
Jump to comment: Most recent file
there seems to be a bug in the logic to decide what's new regarding the core version info. for example, on my test site, running core from the end of the DRUPAL-5 branch, this is marked on the update page:
Drupal 5.2 dev Update available
Recommended version: 5.1 (2007-Jan-30) Download · Release notes
Included modules: Drupal
haven't actually looked into why this is happening yet.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | update_status_core_project.patch_1.txt | 1.98 KB | dww |
| #2 | update_status_core_project.patch.txt | 1.92 KB | dww |
Comments
Comment #1
dwwi see the problem: update_status_get_projects() doesn't correctly think this is a CVS install for core... should be easy to fix. i'll take a stab when i get back from lunch. ;)
Comment #2
dwwlooking deeper, there were a bigger problems with how core modules were associated with the core 'drupal' project when you deploy from CVS. if the .info files didn't have 'project = drupal', then core would only show up if you happened to have the drupal.module itself enabled. ;)
so, we submitted http://drupal.org/node/145801 to see if the core .info files can just define their project directly. however, here's the code to make this work for older versions of core that don't do that. this also fixes the problem of accidentally relying on the drupal.module (this patch works fine whether or not that module is enabled).
also, i fixed up the code to recognize core dev snapshots (which just use "dev" in the version string, not "-dev"). perhaps this is silly, and we should just always check for "dev" in the version string...
Comment #3
merlinofchaos commentedYour special case for core sets it to 'dev' when I think it should set it to 'cvs' if it sees that -- a dev version will have proper version info. It is only the 'cvs' version that won't.
Comment #4
dwwahh, interesting. the core 5.x-dev release tarball has "version = 5.x-dev" in the .info files, whereas the ones from CVS just have "5.2 dev". so, you're right, we can do slightly better than i thought regarding marking these as CVS or not. however, see http://drupal.org/node/146027 (oh, tee hee, which you already have). ;)
anyway, i'll fix up the dev vs. -dev logic in here and repost. stay tuned.
Comment #5
dwwhow's this?
Comment #6
dwwmerlin RTBC'ed this via IRC, so i just committed it to HEAD.
Comment #7
(not verified) commented