Unfortunately, it is possible simply rebook unavailable days, if you select overlapping dates (a date before the booked period and a day after the booked period).
See attachment, blue color is the actual selection of the booking which contains unavailable (yellow) days.
Is there any workaround for this validation problem?

CommentFileSizeAuthor
#12 overnight.png13.69 KBgiupenni
#12 fullyday.png13.28 KBgiupenni
#7 bug_1day_rebook.png19.11 KBszt
acbug2.jpg70.85 KBszt

Comments

fietserwin’s picture

Status: Active » Postponed

When creating the interactive calendar I was aware of this possibility, but decided to not solve this.

First it is still assumed that this module is not handling the complete procedure from start to end, so manual approval of requests is still necessary. Therefore the status is also not automatically updated after a request is sent, though another issue exists to add that feature: #1379384: Custom handling of bookings.

Secondly, other restrictions may apply, e.g. you can only book saturday to saturday, or a minimum of 2 days, etc. All these kind of restrictions are ignored for now (cannot even be modeled) and can only be presented to the user using surrounding text.

Thirdly, how stupid can a seriously interested visitor be to ignore a booked period and do you want such people in your nicely renovated and carefully maintained apartment :)

Concluding, this module is mainly a visual aid. Plans exist to further integrate the booking process, e.g. by integrating with the rooms module. But for now it remains what it is.

Setting to postponed, as it certainly will get some attention in a future release. If you can supply a patch (mainly/completely javascript) that would be highly welcomed.

szt’s picture

Category: bug » feature

Thanks for your answer, you're absolutely right.
Maybe I will work on it.
Set to feature request.

lokz’s picture

quote: Thirdly, how stupid can a seriously interested visitor be to ignore a booked period

you would be surprised. :-)

but, as you said, this is not some important issue. Having calendar and form on one page, or integration with date picker would be more important to handle.
p.s. If you integrate with rooms module, please leave posibility for "inquiry" mode, not only complete online booking mode with payment.

Thanks for this great module.

fietserwin’s picture

Version: 7.x-3.2 » 7.x-4.x-dev
fietserwin’s picture

Title: Overlapping dates » User can select date range with non available dates
Status: Postponed » Fixed

Fixed and committed.

I don't make cells that will result in an invalid range non-selectable, but instead will show an "error icon" in the invalid cell the user clicked on. After 5 seconds it will disappear. I thought about an alert but that is so ugly, but otoh, stupid users deserve ugly, highly interruptive messages. So I might change that in the future.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

szt’s picture

Version: 7.x-4.x-dev » 7.x-5.x-dev
Issue summary: View changes
Status: Closed (fixed) » Active
StatusFileSize
new19.11 KB

Hi fietserwin,
thanks for the feature, works well, but there is one small piece.
You can rebook any "single" booked day.
See attachment.

giupenni’s picture

This issue can be partially fixed adding this css property:

.cal-na.cal-selectable {
    pointer-events: none;
}
giupenni’s picture

Why in demostration page this problem is not present?

  • fietserwin committed cc77096 on 7.x-5.x
    [#1451180]: User can select date range with non available dates.
    
fietserwin’s picture

Status: Active » Closed (fixed)

I finally found some time (and motivation) to dive into this problem. It occurs with overnight calendars where "selectable" and "available" are not completely the same: you may click on a non-available date as departure date, if the day before is "available" (thus such a date is selectable but not available). However, I was checking on the first. So I corrected that check.

giupenni’s picture

StatusFileSize
new13.28 KB
new13.69 KB

Thank you fietserwin to spent your time for this but the problem is present also with Full day rental/allocation.
Anyway, I've tried also with Overnight rental/allocation but the problem is still present.

I've already cleared the cache and executed update.php

Thank you very much to spent your time for community.

giupenni’s picture

Status: Closed (fixed) » Needs work
giupenni’s picture

Damn.

I'm so sorry, my mistake.

In admin/config/content/availability-calendar I've accidentally set Fully booked as available.

The module now works like a charm with your patch.

Thank you very much fietserwin for your time and motivation.

giupenni’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.