Node template: pre-themed $submitted variable should be used instead of theming it in the template [#1451330]

Drupal core themes the author name and published date in theme_preprocess_node() and makes it available as the $submitted variable. I think that Omega should follow this behavior and simply print the $submitted variable in node.tpl.php instead of ignoring it and re-theming the output.

Currently in Omega 3.1 node.tpl.php:

<?php if ($display_submitted): ?>
<footer class="submitted"><?php print $date; ?> -- <?php print $name; ?></footer>
<?php endif; ?>

It seem silly to have to override the node.tpl.php file just to update the author and publishing info formatting.

Can Omega not implement theme_preprocess_node() to implement any customization over core?

I can roll a patch if y'all think this is the right way of doing things.

Comment	File	Size	Author
#5	submitted-node-template--1451330--5.patch	1.03 KB	jessehs
#2	submitted-node-template--1451330--2.patch	1.04 KB	jessehs

Comments

Comment #1

star-szr

he/him

English

commented 1 March 2012 at 14:56

+1 from me. Shouldn't be hardcoded in node.tpl.php.

Comment #2

jessehs

he/him

English

Taos, New Mexico

commented 1 March 2012 at 18:23

Version:	7.x-3.1	» 7.x-3.x-dev
Status:	Active	» Needs review

Status	File	Size
new	submitted-node-template--1451330--2.patch	1.04 KB

Here's a patch. Please test. (I patched using patch -p1 command.)

Comment #3

star-szr

he/him

English

commented 1 March 2012 at 20:03

Status:

Needs review

» Needs work

Funny, I wrote almost the exact same code earlier in my subtheme, foo and all.

+++ b/omega/template.phpundefined
@@ -145,6 +145,11 @@ function omega_alpha_preprocess_node(&$vars) {
+    $vars['submitted'] = $vars['date'] . ' -- ' . $vars['name']  . 'foo';

Lose the foo :)

+++ b/omega/templates/node.tpl.phpundefined
@@ -7,8 +7,8 @@
+  <?php if ($display_submitted && $submitted): ?>

I used this condition as well, because I wanted to hide the submitted date from my teasers.

Once the foo is gone this gets my recommendation.

Comment #4

marcoka commented 1 March 2012 at 20:52

Assigned:

Unassigned

» himerus

Comment #5

jessehs

he/him

English

Taos, New Mexico

commented 1 March 2012 at 21:04

Status	File	Size
new	submitted-node-template--1451330--5.patch	1.03 KB

Ha ha! Whoops!

Here you go.

Comment #6

jessehs

he/him

English

Taos, New Mexico

commented 1 March 2012 at 21:06

Status:

Needs work

» Needs review

Comment #7

datagroove_ commented 15 March 2012 at 14:07

+1
question though, the $date var is a string, how do we edit the strings format?

Comment #8

jessehs

he/him

English

Taos, New Mexico

commented 16 March 2012 at 00:28

@datagroove_, I believe that the default $date variable is set by setting the Medium date format at the Date and time config page (path is /admin/config/regional/date-time in Drupal 7).