The administration settings are in the admin category "content management" (admin/content) which IMO does not fit. I think it should be under "site configuration" (admin/settings).

The help text already points to "site configuration" for some reason.

... For more information, see <a href="@admin-help-system">cron</a>.</li><li>administer notify <a href="@admin-settings-notify">administer &gt;&gt; settings &gt;&gt; notify</a>.</li></ul>', array('@admin-help-system' => url('admin/help/system'), '@admin-settings-notify' => url('admin/settings/notify'))...

Patch against HEAD included.

CommentFileSizeAuthor
#4 content.to_.setting.move_.patch3.78 KBbeginner
#3 notification_settings_wreadme.patch.txt1.62 KBStandart
notification_settings.patch.txt710 bytesStandart

Comments

stella’s picture

stella commented
Status: Active » Reviewed & tested by the community

I agree with this. The notify configuration page should be located under admin/settings rather than admin/content as it currently is. At the very least the help text should contain the correct info.

I've tested this patch and it all works fine. Rob - can you apply this to CVS please?

Cheers,
Stella

beginner’s picture

beginner commented
Category: task » bug
Status: Reviewed & tested by the community » Needs work

This can be considered a bug. I'll notice it better this way.

The README text should be modified accordingly.

Standart’s picture

Standart commented
Status: Needs work » Needs review
StatusFileSize
new notification_settings_wreadme.patch.txt1.62 KB

Added changes to README.

beginner’s picture

beginner commented
Status: Needs review » Fixed
StatusFileSize
new content.to_.setting.move_.patch3.78 KB

The patch was good.

I had to modify hook_menu(), too, in consideration for this patch that just got committed.
http://drupal.org/node/146521#comment-272327

Also, I added a notify_update_2() because the cache had to be cleared for users to see the change. A message is printed to warn administrators.

The patch attached was committed.

beginner’s picture

beginner commented

http://drupal.org/cvs?commit=73652

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)