Notification settings under "site configuration" instead "content management"

Standart - May 18, 2007 - 23:03
Project:Notify
Version:HEAD
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed
Description

The administration settings are in the admin category "content management" (admin/content) which IMO does not fit. I think it should be under "site configuration" (admin/settings).

The help text already points to "site configuration" for some reason.

... For more information, see <a href="@admin-help-system">cron</a>.</li><li>administer notify <a href="@admin-settings-notify">administer &gt;&gt; settings &gt;&gt; notify</a>.</li></ul>', array('@admin-help-system' => url('admin/help/system'), '@admin-settings-notify' => url('admin/settings/notify'))...

Patch against HEAD included.

AttachmentSize
notification_settings.patch.txt710 bytes

#1

stella - May 22, 2007 - 09:32
Status:active» patch (reviewed & tested by the community)

I agree with this. The notify configuration page should be located under admin/settings rather than admin/content as it currently is. At the very least the help text should contain the correct info.

I've tested this patch and it all works fine. Rob - can you apply this to CVS please?

Cheers,
Stella

#2

beginner - July 9, 2007 - 07:58
Category:task» bug report
Status:patch (reviewed & tested by the community)» patch (code needs work)

This can be considered a bug. I'll notice it better this way.

The README text should be modified accordingly.

#3

Standart - July 10, 2007 - 07:49
Status:patch (code needs work)» patch (code needs review)

Added changes to README.

AttachmentSize
notification_settings_wreadme.patch.txt1.62 KB

#4

beginner - July 15, 2007 - 03:12
Status:patch (code needs review)» fixed

The patch was good.

I had to modify hook_menu(), too, in consideration for this patch that just got committed.
http://drupal.org/node/146521#comment-272327

Also, I added a notify_update_2() because the cache had to be cleared for users to see the change. A message is printed to warn administrators.

The patch attached was committed.

AttachmentSize
content.to_.setting.move_.patch3.78 KB

#5

beginner - July 15, 2007 - 03:14

#6

Anonymous - July 29, 2007 - 03:16
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.