Hello,

As I understand Entity Cache saves any comment in a state when it was 1st rendered. As a result I always see "new" marker in comments unless I flush cache. If I disable the module this marker works as expected (apperas only once based on 'history' table information).

Is there any way to fix this? The only way I see - is to work with 'history' table directly which is not the way I like it.

I'd appreciate any help or idea,
Thanlks

CommentFileSizeAuthor
#4 entitycache-1451752.patch617 bytestobiasb

Comments

catch’s picture

catch
he/him
Primary language English
commented
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Active » Fixed

Comment module does this in attachLoad() - $comment->new = node_mark($comment->nid, $comment->changed);

Should be fixed in http://drupalcode.org/project/entitycache.git/commit/9116951

Georgii’s picture

Georgii commented

Thank you, catch!
I'll try to test this in the nearest future.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Issue summary: View changes
Status: Closed (fixed) » Needs review
StatusFileSize
new entitycache-1451752.patch617 bytes

The arguments $comments is not by reference, therefore it can not work.

skwashd’s picture

skwashd commented
Status: Needs review » Needs work
Issue tags: +Needs tests

@tobiasb this patch looks good, but this is something that really needs test coverage.

Jorrit’s picture

Jorrit commented

The array is not passed by reference but it contains a reference to the comment object, not the comment object itself. So changing a value on the reference does change it in the object, not just in the object in this array. Did you test if this was necessary?