Sometimes you get a notice when you are trying to login as a facebook user.
The problem is caused by the fboauth.fboauth.inc file, because it is called the array_shift php function, by taking an argument that is the result of the user_load_multiple function. Because of this, you get a notice.

CommentFileSizeAuthor
#2 1451856-fboauth-simple-load-account-by-mail.patch698 bytesdave reid
fboauth-notice-arg-by-reference.patch5.29 KBhac441

Comments

wedge’s picture

wedge commented

Patch fixed this notice for me. Thanks!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-1.4 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new 1451856-fboauth-simple-load-account-by-mail.patch698 bytes

I think this simpler patch should solve it as well.

quicksketch’s picture

quicksketch
he/him
commented

Thanks, Dave! Though I think the && operator fires before the assignment operator, so I think we'd better wrap the second conditional in parathesis.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Only if it's *not* the last condition. Otherwise it's totally fine. :)

quicksketch’s picture

quicksketch
he/him
commented
Title: Argument passed by reference » PHP notice (variable passed by reference) when attempting to bind e-mails to existing accounts
Status: Needs review » Fixed

Thanks committed!

Automatically closed -- issue fixed for 2 weeks with no activity.