Uninstall of bookreview module

thierry_gd - May 19, 2007 - 13:19
Project:Book Review
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:humaneasy
Status:closed
Description

Adding the following lines at the end of .install file will allow the module to be properly uninstalled

/**
* Implementation of hook_uninstall().
*/
function bookreview_uninstall() {
db_query('DROP TABLE {bookreview}');
db_query('DROP TABLE {bookreview_links}');
db_query('DROP TABLE {bookreview_authors}');
}

#1

Susurrus - January 18, 2008 - 02:49
Status:active» needs work

Looks good, though while we're add it, all variables defined by the bookreview module should be cleared. These variables are listed below:

  • bookreview_store_blocktitle
  • bookreview_store_snippet
  • minimum_bookreview_size
  • bookreview_detail
  • bookreview_css
  • bookreview_help

This should really be re-released as a patch, which I might do later if I have time. But before that is done, I suggest adding variable_del() calls for all the listed variables to finalize this cleanup.

#2

humaneasy - March 6, 2008 - 12:07
Status:needs work» needs review

I made a new bookreview.install because it was wrong even in the hook_install portion.
Also added the PgSQL section but this really needs review.

Attached here.

AttachmentSize
bookreview_install.zip 1.06 KB

#3

humaneasy - March 6, 2008 - 12:25
Component:Documentation» Code
Priority:normal» critical
Assigned to:Anonymous» humaneasy

It is done just needs review.

It is critical because anyone that uses the included one on the D5 package and use also database prefix will have issues as you can see at issue #225333.

#4

Susurrus - April 3, 2008 - 21:41

Can you reroll this as a patch? Then I can test it.

#5

humaneasy - May 27, 2008 - 12:32

Here it goes. But it would work if you just replace the current bookreview.install file by the new one :)

AttachmentSize
bookreview.install.patch 4.92 KB

#6

humaneasy - September 7, 2009 - 21:55
Status:needs review» fixed

#7

System Message - September 21, 2009 - 22:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.