Posted by thierry_gd on May 19, 2007 at 1:19pm
| Project: | Book Review |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | humaneasy |
| Status: | closed (fixed) |
Issue Summary
Adding the following lines at the end of .install file will allow the module to be properly uninstalled
/**
* Implementation of hook_uninstall().
*/
function bookreview_uninstall() {
db_query('DROP TABLE {bookreview}');
db_query('DROP TABLE {bookreview_links}');
db_query('DROP TABLE {bookreview_authors}');
}
Comments
#1
Looks good, though while we're add it, all variables defined by the bookreview module should be cleared. These variables are listed below:
This should really be re-released as a patch, which I might do later if I have time. But before that is done, I suggest adding variable_del() calls for all the listed variables to finalize this cleanup.
#2
I made a new bookreview.install because it was wrong even in the hook_install portion.
Also added the PgSQL section but this really needs review.
Attached here.
#3
It is done just needs review.
It is critical because anyone that uses the included one on the D5 package and use also database prefix will have issues as you can see at issue #225333.
#4
Can you reroll this as a patch? Then I can test it.
#5
Here it goes. But it would work if you just replace the current bookreview.install file by the new one :)
#6
#7
Automatically closed -- issue fixed for 2 weeks with no activity.