While going through this example I noticed that the descriptive text is wrong, and contains a small typo.

It says:

In a javascript environment, the "Choose" button next to the select control if displayed; in a non-js environment it is hidden by the module CSS.

But this is the opposite of what really happens - the choose button is only shown when Javascript is disabled (I confirmed this by turning mine off and refreshing). Also that "if displayed" should read "is displayed".

Patch for these two little changes attached. I also made a 7.x backport, will attach that too in a comment.

CommentFileSizeAuthor
#3 examples-ajax_graceful_text_correction_7.x-1452700-3.patch1.14 KBdamien_vancouver
#2 examples-ajax_graceful_text_correction_8.x.patch1.14 KBrfay
examples-ajax_graceful_text_correction_8.x.patch1.14 KBdamien_vancouver

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Version: » 7.x-1.x-dev

Thanks so much! This is deferred because 8.x doesn't pass tests. I'm going to try it on D7.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new examples-ajax_graceful_text_correction_8.x.patch1.14 KB

OP patch again, for D7

damien_vancouver’s picture

damien_vancouver commented
StatusFileSize
new examples-ajax_graceful_text_correction_7.x-1452700-3.patch1.14 KB

Ah that's why it didn't test! I was patiently waiting. ;)

I made one specifically against 7. I see the 8.x one passed anyway, but might as well attach this one too. Thanks!

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Committed to D7, http://drupalcode.org/project/examples.git/commitdiff/da172b7

Thanks so much!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.