I'm running recent changes and the spam module. When suspected spam is automatically unpublished, it still shows up in recent changes. After some thought, I realize this might not be a bug per se, but it would nice to either flag things as unpublished (so admins don't worry that some spam slipped in) or have an admin setting option to show or hide unpublished items.

If this isn't a priority for any one else, I'll probably just hack the SQL to add "WHERE publish=1"... but I thought I'd just throw it out there.

Thanks

CommentFileSizeAuthor
#3 unpublish.patch561 bytesmicheleannj

Comments

toemaz’s picture

toemaz commented

I concur with this. Will you create a patch?
Providing a patch to the project developer would make it easier for him to test and to commit.

micheleannj’s picture

micheleannj commented

Will do... look for it in the next day or two...

Thanks for the quick response.

maj

micheleannj’s picture

micheleannj commented
Status: Active » Needs review
StatusFileSize
new unpublish.patch561 bytes

Here's a tiny patch to hide unpublished nodes (including those marked spam) from recent changes.

Will submit another one when/if I can figure out how to:

a)add an admin option to show or not
b)add another checkbox on the recent changes page (like the current 'show comments' option)

both of these are beyond the small hacks I've done so far, so I'd appreciate help on how to proceed.

thanks

toemaz’s picture

toemaz commented

Concerning the extra options you would like to add: I wouldn't advice you to make these. The recent changes module should be used for tracking recent changes, and not cleaning out spam or anything else. That should be taken care of by another module, preferly the in core (node/comment) module or the anti-spam module. So my advice: leave the patch as it is.

At first sight the patch looks ok, but I will have to check it bc I'm not sure whether you would replace the published field by the status field.

micheleannj’s picture

micheleannj commented

Hmmm... my thought was that marking something as spam would be a "change" ... Sort of a reverse of the Mediawiki "unpatrolled edit" flag.

But I'm fine with keeping the change to myself.

Thanks again for a great module!

iamwhoiam’s picture

iamwhoiam commented
Version: 5.x-1.x-dev » 6.x-1.x-dev

Hi all. I've just installed 6.x dev version and I'm also trying to show unpublished stories. However, there is no option in recent changes to change this. I think it would be an important thing to include because Recent Changes is very useful for editor moderation.

iamwhoiam’s picture

iamwhoiam commented

Found it... remove AND n.status >= 1 condition from $revisions_query database query

toemaz’s picture

toemaz commented
Status: Needs review » Closed (fixed)

It's probably more interesting now to create a View and try to match it as much as possible with the recent changes module. This module may become obsolete then.